From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [net-next PATCH 2/5] udp: Do not pass checksum or MSS as parameters Date: Thu, 3 May 2018 18:56:01 -0700 Message-ID: <8af90541-068f-67af-ce80-8a4be647c616@gmail.com> References: <20180504002817.4496.64616.stgit@localhost.localdomain> <20180504003326.4496.54432.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Alexander Duyck , netdev@vger.kernel.org, willemb@google.com, davem@davemloft.net Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:43283 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbeEDB4D (ORCPT ); Thu, 3 May 2018 21:56:03 -0400 Received: by mail-pf0-f195.google.com with SMTP id j20so1875768pff.10 for ; Thu, 03 May 2018 18:56:03 -0700 (PDT) In-Reply-To: <20180504003326.4496.54432.stgit@localhost.localdomain> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/03/2018 05:33 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to be a start at cleaning up some of the UDP GSO > segmentation code. Specifically we were passing mss and a recomputed > checksum when we really didn't need to. The function itself could derive > that information based on the already provided checksum, the length of the > packet stored in the UDP header, and the gso_size. > > Signed-off-by: Alexander Duyck > --- > include/net/udp.h | 3 +- > net/ipv4/udp_offload.c | 61 +++++++++++++++++++++++++++++++----------------- > net/ipv6/udp_offload.c | 7 +----- > 3 files changed, 41 insertions(+), 30 deletions(-) > There are really a lot of changes in this patch (not mentioned in changelog). Can you please split all this in small patches ?