[PATCH iproute2-next 0/1] tc: fix typo in netem's usage string

[PATCH iproute2-next 0/1] tc: fix typo in netem's usage string

[francois.michel]

From: François Michel <francois.michel@uclouvain.be>

Fixes a misplaced newline in netem's usage string.

François Michel (1):
  tc: fix typo in netem's usage string

 tc/q_netem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: a79e2b2e546584b2879cb9fedd42b7fec5cc8c61
-- 
2.41.0

[PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

[francois.michel]

From: François Michel <francois.michel@uclouvain.be>

Signed-off-by: François Michel <francois.michel@uclouvain.be>
---
 tc/q_netem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/q_netem.c b/tc/q_netem.c
index febddd49..3be647ff 100644
--- a/tc/q_netem.c
+++ b/tc/q_netem.c
@@ -31,7 +31,7 @@ static void explain(void)
 		"                 [ loss random PERCENT [CORRELATION]]\n"
 		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
 		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
-		"                 [ seed SEED \n]"
+		"                 [ seed SEED ]\n"
 		"                 [ ecn ]\n"
 		"                 [ reorder PERCENT [CORRELATION] [ gap DISTANCE ]]\n"
 		"                 [ rate RATE [PACKETOVERHEAD] [CELLSIZE] [CELLOVERHEAD]]\n"
-- 
2.41.0

Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

[Petr Machata]

francois.michel@uclouvain.be writes:

> From: François Michel <francois.michel@uclouvain.be>
>
> Signed-off-by: François Michel <francois.michel@uclouvain.be>

Reviewed-by: Petr Machata <petrm@nvidia.com>

That said...

>  		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>  		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"

... and sorry for piling on like this, but since we are in the domain of
fixing netem typos, if you would also fix the missing brackets on these
two lines, that would be awesome.

Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

[David Ahern]

On 8/30/23 9:32 AM, Petr Machata wrote:
> ... and sorry for piling on like this, but since we are in the domain of
> fixing netem typos, if you would also fix the missing brackets on these
> two lines, that would be awesome.

yes, please and a separate patch.

Re: [PATCH iproute2-next 0/1] tc: fix typo in netem's usage string

[David Ahern]

On 8/30/23 9:05 AM, francois.michel@uclouvain.be wrote:
> From: François Michel <francois.michel@uclouvain.be>
> 
> Fixes a misplaced newline in netem's usage string.
> 
> François Michel (1):
>   tc: fix typo in netem's usage string
> 
>  tc/q_netem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> base-commit: a79e2b2e546584b2879cb9fedd42b7fec5cc8c61

single patch PRs do not need a cover letter. I have fixed up this one;
in the future just send the 1 patch with a proper description.

Re: [PATCH iproute2-next 0/1] tc: fix typo in netem's usage string

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Wed, 30 Aug 2023 17:05:20 +0200 you wrote:
> From: François Michel <francois.michel@uclouvain.be>
> 
> Fixes a misplaced newline in netem's usage string.
> 
> François Michel (1):
>   tc: fix typo in netem's usage string
> 
> [...]

Here is the summary with links:
  - [iproute2-next,1/1] tc: fix typo in netem's usage string
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=865dd3ab1580

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

[Donald Hunter]

Petr Machata <petrm@nvidia.com> writes:

> francois.michel@uclouvain.be writes:
>
>> From: François Michel <francois.michel@uclouvain.be>
>>
>> Signed-off-by: François Michel <francois.michel@uclouvain.be>
>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
>
> That said...
>
>>  		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>  		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>
> ... and sorry for piling on like this, but since we are in the domain of
> fixing netem typos, if you would also fix the missing brackets on these
> two lines, that would be awesome.

The tc-netem(8) man page suggests (and usage confirms) that P14 is also
an optional parameter so it should be bracketed as well.

https://www.man7.org/linux/man-pages/man8/tc-netem.8.html

Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

[François Michel]

Hi,

Le 31/08/23 à 11:05, Donald Hunter a écrit :
> Petr Machata <petrm@nvidia.com> writes:
> 
>> francois.michel@uclouvain.be writes:
>>
>>> From: François Michel <francois.michel@uclouvain.be>
>>>
>>> Signed-off-by: François Michel <francois.michel@uclouvain.be>
>>
>> Reviewed-by: Petr Machata <petrm@nvidia.com>
>>
>> That said...
>>
>>>   		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>>   		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>>
>> ... and sorry for piling on like this, but since we are in the domain of
>> fixing netem typos, if you would also fix the missing brackets on these
>> two lines, that would be awesome.
> 
> The tc-netem(8) man page suggests (and usage confirms) that P14 is also
> an optional parameter so it should be bracketed as well.

Allright. While we're at it, I'll will also probably unify the spaces 
around brackets. On other qdiscs, brackets seem to be systematically 
surrounded by spaces.

François

> 
> https://www.man7.org/linux/man-pages/man8/tc-netem.8.html