Re: [PATCH net-next v7 2/2] r8152: Add support for the RTL8157 hardware

Birger Koblitz
2026-04-09T11:19:00Z

On 09/04/2026 12:16, Paolo Abeni wrote:
> On 4/4/26 9:57 AM, Birger Koblitz wrote:
>> @@ -6534,8 +6842,11 @@ static void rtl8156_up(struct r8152 *tp)
>> ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3,
>> PLA_MCU_SPDWN_EN);
>>
>> - ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_SPEED_OPTION,
>> - RG_PWRDN_EN | ALL_SPEED_OFF);
>> + ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
>
> AI review notes that the above leads to 2 consecutive:
>
> ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
>
> with slightly different formatting, likely C&P error?!?
>
> I think this is better handled with a follow-up, if needed, as I don't
> see any possible issue out of it.
>
> Other AI comments look not relevant.
Thanks a lot, Paolo!
I will follow up on this for sure, there is also the RTL8159...
I also contacted the Realtek devs, but have not heard back so far, probably needs
internal escalation...

Birger