From: Andrew Lunn <andrew@lunn.ch>
To: xiaopeitux@foxmail.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Pei Xiao <xiaopei01@kylinos.cn>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] net: freescale: ucc_geth: make ugeth_mac_ops be static
Date: Fri, 14 Feb 2025 14:14:29 +0100 [thread overview]
Message-ID: <8b45aa58-3128-44b0-9408-3d7794436cd4@lunn.ch> (raw)
In-Reply-To: <tencent_832FF5138D392257AC081FEE322A03C84907@qq.com>
On Fri, Feb 14, 2025 at 02:11:07PM +0800, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> sparse warning:
> sparse: symbol 'ugeth_mac_ops' was not declared. Should it be
> static.
>
> Add static to fix sparse warnings.
While you are touching it, can it also be made const?
struct phylink *phylink_create(struct phylink_config *,
const struct fwnode_handle *,
phy_interface_t,
const struct phylink_mac_ops *);
phylink_create() will accept a const struct *.
Andrew
prev parent reply other threads:[~2025-02-14 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 6:11 [PATCH] net: freescale: ucc_geth: make ugeth_mac_ops be static xiaopeitux
2025-02-14 8:27 ` Maxime Chevallier
2025-02-14 13:14 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b45aa58-3128-44b0-9408-3d7794436cd4@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox