From: "Arinzon, David" <darinzon@amazon.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Allen, Neil" <shayagr@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Leon Romanovsky <leon@kernel.org>
Subject: RE: [PATCH v9 net-next 5/8] net: ena: Add debugfs support to the ENA driver
Date: Thu, 22 May 2025 05:24:10 +0000 [thread overview]
Message-ID: <8b4dc75950b24bd6a98cb26661533f70@amazon.com> (raw)
In-Reply-To: <0754879f-5dbe-4748-8af3-0a588c90bcc0@lunn.ch>
> > +void ena_debugfs_init(struct net_device *dev) {
> > + struct ena_adapter *adapter = netdev_priv(dev);
> > +
> > + adapter->debugfs_base =
> > + debugfs_create_dir(dev_name(&adapter->pdev->dev), NULL);
> > + if (IS_ERR(adapter->debugfs_base))
> > + netdev_err(dev, "Failed to create debugfs dir\n");
>
> Don't check return codes from debugfs_ calls. It does not matter if it fails, it is
> just debug, and all debugfs_ calls are happy to take a NULL pointer,
> ERR_PTR() etc.
>
> Andrew
Thank you for the feedback.
We were looking to get a failure indication and not continue creating the rest of the nodes (patch 6/8).
Will make the changes in the patches and send a v10.
David
next prev parent reply other threads:[~2025-05-22 5:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 11:42 [PATCH v9 net-next 0/8] PHC support in ENA driver David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 1/8] net: ena: Add PHC support in the " David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 2/8] net: ena: PHC silent reset David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 3/8] net: ena: Add device reload capability through devlink David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 4/8] net: ena: Control PHC enable " David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 5/8] net: ena: Add debugfs support to the ENA driver David Arinzon
2025-05-21 12:38 ` Andrew Lunn
2025-05-22 5:24 ` Arinzon, David [this message]
2025-05-22 12:30 ` Andrew Lunn
2025-05-22 13:08 ` Arinzon, David
2025-05-21 11:42 ` [PATCH v9 net-next 6/8] net: ena: View PHC stats using debugfs David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 7/8] net: ena: Add PHC documentation David Arinzon
2025-05-21 11:42 ` [PATCH v9 net-next 8/8] net: ena: Add a DEVLINK readme David Arinzon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4dc75950b24bd6a98cb26661533f70@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=andrew@lunn.ch \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=vadim.fedorenko@linux.dev \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).