From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from struct rtl8169_private
Date: Tue, 10 Jul 2018 23:32:36 +0200 [thread overview]
Message-ID: <8b78b589-3d6c-65f4-d39a-2ce708af8220@gmail.com> (raw)
In-Reply-To: <20180710210036.GK892@lunn.ch>
On 10.07.2018 23:00, Andrew Lunn wrote:
>> @@ -6719,7 +6703,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>> if (ret)
>> return ret;
>>
>> - if (!tp->mii.supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
>> + if (!tp->supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
>
> It is better to use phy_set_max_speed() with SPEED_100 if
> tp->supports_gmii is not set.
>
Then the info message wouldn't fit any longer, it's meaningful in case
1GBit PHY + 100MBit MAC only.
> Andrew
>
next prev parent reply other threads:[~2018-07-10 21:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 18:29 [PATCH net-next v2 00/10] r8169: add phylib support Heiner Kallweit
2018-07-10 18:39 ` [PATCH net-next v2 01/10] r8169: add basic " Heiner Kallweit
2018-07-10 19:10 ` Andrew Lunn
2018-07-10 19:20 ` Heiner Kallweit
2018-07-10 18:39 ` [PATCH net-next v2 02/10] r8169: use phy_resume/phy_suspend Heiner Kallweit
2018-07-10 19:15 ` Andrew Lunn
2018-07-10 19:32 ` Heiner Kallweit
2018-07-10 20:52 ` Andrew Lunn
2018-07-10 21:42 ` Heiner Kallweit
2018-07-10 21:56 ` Heiner Kallweit
2018-07-10 18:39 ` [PATCH net-next v2 03/10] r8169: replace open-coded PHY soft reset with genphy_soft_reset Heiner Kallweit
2018-07-11 11:10 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 04/10] r8169: use phy_ethtool_(g|s)et_link_ksettings Heiner Kallweit
2018-07-10 20:34 ` Andrew Lunn
2018-07-11 11:10 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 05/10] r8169: use phy_ethtool_nway_reset Heiner Kallweit
2018-07-11 11:11 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 06/10] r8169: use phy_mii_ioctl Heiner Kallweit
2018-07-11 11:11 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 07/10] r8169: migrate speed_down function to phylib Heiner Kallweit
2018-07-10 20:44 ` Andrew Lunn
2018-07-10 21:26 ` Heiner Kallweit
2018-07-10 21:40 ` Andrew Lunn
2018-07-10 18:39 ` [PATCH net-next v2 08/10] r8169: remove rtl8169_set_speed_xmii Heiner Kallweit
2018-07-10 18:40 ` [PATCH net-next v2 09/10] r8169: remove mii_if_info member from struct rtl8169_private Heiner Kallweit
2018-07-10 20:53 ` Andrew Lunn
2018-07-10 21:00 ` Andrew Lunn
2018-07-10 21:32 ` Heiner Kallweit [this message]
2018-07-10 21:37 ` Andrew Lunn
2018-07-10 18:40 ` [PATCH net-next v2 10/10] r8169: don't read chip phy status register Heiner Kallweit
2018-07-11 11:12 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b78b589-3d6c-65f4-d39a-2ce708af8220@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).