From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from
 struct rtl8169_private
Date: Tue, 10 Jul 2018 23:32:36 +0200
Message-ID: <8b78b589-3d6c-65f4-d39a-2ce708af8220@gmail.com>
References: <84ac1cb7-bafd-5f15-8cda-e8dfd7d0deb3@gmail.com>
 <aaa67fd8-9039-0786-96fa-0803db280c97@gmail.com>
 <20180710210036.GK892@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f65.google.com ([209.85.221.65]:46174 "EHLO
        mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732261AbeGJVdm (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 10 Jul 2018 17:33:42 -0400
Received: by mail-wr1-f65.google.com with SMTP id s11-v6so16056920wra.13
        for <netdev@vger.kernel.org>; Tue, 10 Jul 2018 14:32:42 -0700 (PDT)
In-Reply-To: <20180710210036.GK892@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10.07.2018 23:00, Andrew Lunn wrote:
>> @@ -6719,7 +6703,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>>  	if (ret)
>>  		return ret;
>>  
>> -	if (!tp->mii.supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
>> +	if (!tp->supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
> 
> It is better to use phy_set_max_speed() with SPEED_100 if
> tp->supports_gmii is not set.
> 
Then the info message wouldn't fit any longer, it's meaningful in case
1GBit PHY + 100MBit MAC only.

> 	  Andrew
>