From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEF5531E834 for ; Sun, 30 Aug 2026 07:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788075887; cv=none; b=NTidtBJikPlHp10s1AsiEladDgQAgGm8xn6eX4jdKiJKtR71QJcLquwFSV61baob7GJyeV5CLuuXQrtfz/eMilwmJhzrZtQ63wvSqe4CuUMtWiXtv9ydB8wTwnokb6ZLtdJfSOdlTD3gqmG4Ly4tP+F4LkUpRCjPMOb5xgkka4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788075887; c=relaxed/simple; bh=siwPox7XnJfshy176BADfYsCKlayjDwRqX7ETEaOW0M=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=SauxKi0WAs2wGP23TsNQviGvtonML89uBhh8CpcHFLjhpQbgijsNrZFgT8/Puwwijwzfp24smr0/XvJtNQ+p/fTEoR6c3AEtc8SejTQSc7DALX96flfyjyZWVRrfL9xIaO/xrWK7LraKP4s8W+BTdSnpXPgLShK2t09TWo3dxuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HSQQXL0r; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HSQQXL0r" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 03F1F4E41442; Sun, 30 Aug 2026 07:44:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BA37D603CB; Sun, 30 Aug 2026 07:44:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4673511C7838E; Sun, 30 Aug 2026 09:44:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788075871; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=IkgJyU5CnuE4BnlMElNZDOZylUlvGQ+88uBom0ae/JU=; b=HSQQXL0r7CzNA1GNiOPyVmFwLyo8wtRokIQTh1qUxiWhj2TzG1WuUoIuBjqRY8VaE1P+Uo Oqb3XC0BzkcU/JTdC7iyYDWvD1QwTMwuhRSq2sx4PP+mADdVvYXs/EH2z+LjNwuQB1k1T/ 2+DnRLd6zdRLrz/u5ruMX/OAKNvWD/aRe0zq1Z2keqRHR/JrcBrSva2xBrYWsPpA3gpg/2 Zl0cEsdbMFVQ24Ngtb/jP1GRfnrdu+YxP8R6lOc6Vp0zFL0fpfnMqMeHqIrYnTNz5i1o3p aQGiQ8S+mG/INUOLSsUedlesVl/n8O38ErRIqmj6Hu8upuDjcna7vMtIkfrbkA== Message-ID: <8b798b8a-0fb3-4978-8d9d-38616ab25741@bootlin.com> Date: Sun, 30 Aug 2026 09:44:25 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: stmmac: stm32: Set TSO/TBS Tx queues default settings From: Maxime Chevallier To: Kurt Kanzenbach , Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Lorenzo Bianconi References: <20260812-stm32mp2_txtime-v1-1-f9e2462cc85d@linutronix.de> <20260817103337.74c30adc@kernel.org> <87mrujzzjv.fsf@jax.kurt.home> <20260818075335.48936b08@kernel.org> <87h5kq1s1f.fsf@jax.kurt.home> <20260820144528.7107ba90@kernel.org> <87y0e0x7ic.fsf@jax.kurt.home> <5693c628-dffb-46c4-8f7c-5a5a6c101660@bootlin.com> Content-Language: en-US In-Reply-To: <5693c628-dffb-46c4-8f7c-5a5a6c101660@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 8/21/26 15:41, Maxime Chevallier wrote: > Hi Kurt, (Sorry Kurt this has nothing to do with your patch, I'm following-up with some stuff I said on that thread) >> However, we need to keep track of what SoC implementation can enable TBS >> on which queue. For gmac4 we can probably reuse tbs_en and for xgmac >> there's is capability field tbs_ch_num. Let's see. > > Thanks for tackling this, let me know if you need testing. In the past weeks > I've been looking deep in my drawers as well as on various online shops, and > I'm starting to have a farily comprehensive set of stmmac-enabled devices > (although I couldn't get my hands on XGMAC, AgileX5 devkits appear to be way > outside my budget). Made an intersting finding yesterday, maybe it's already known stuff, but it turns out it's easier to find a DRIVER for XGMAC than an actual device... Looking at register layouts and at some then-removed copyright notices from the history, it seems we have not one, not two, but three different drivers upstream for the same DWXGMAC IP : - stmmac's dwxgmac - AMD's XGBE drives a designware XGMAC - Samsung's SXGBE also drives a designware XGMAC No wonder the xgbe selftests were doing the same as the stmmac selftests :) I think reuniting the codebases isn't gonna happen in the near future, however it could be a good idea to hack stmmac to work on amd HW could be a good way to validate the stmmac dwxgmac code, with another reference driver... Maxime