From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
Wei Wang <weiwan@google.com>, Coco Li <lixiaoyan@google.com>
Subject: Re: [PATCH net-next] tcp: move sysctl_tcp_l3mdev_accept to netns_ipv4_read_rx
Date: Wed, 9 Oct 2024 09:12:59 -0600 [thread overview]
Message-ID: <8b946bb4-4918-4072-9f6c-d7cfc96f1f48@kernel.org> (raw)
In-Reply-To: <20241009150504.2871093-1-edumazet@google.com>
On 10/9/24 9:05 AM, Eric Dumazet wrote:
> sysctl_tcp_l3mdev_accept is read from TCP receive fast path from
> tcp_v6_early_demux(),
> __inet6_lookup_established,
> inet_request_bound_dev_if().
>
> Move it to netns_ipv4_read_rx.
>
> Remove the '#ifdef CONFIG_NET_L3_MASTER_DEV' that was guarding
> its definition.
>
> Note this adds a hole of three bytes that could be filled later.
>
> Fixes: 18fd64d25422 ("netns-ipv4: reorganize netns_ipv4 fast path variables")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Wei Wang <weiwan@google.com>
> Cc: Coco Li <lixiaoyan@google.com>
> ---
> .../networking/net_cachelines/netns_ipv4_sysctl.rst | 2 +-
> include/net/netns/ipv4.h | 5 ++---
> net/core/net_namespace.c | 4 +++-
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-10-09 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 15:05 [PATCH net-next] tcp: move sysctl_tcp_l3mdev_accept to netns_ipv4_read_rx Eric Dumazet
2024-10-09 15:12 ` David Ahern [this message]
2024-10-10 2:58 ` Jakub Kicinski
2024-10-10 3:33 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b946bb4-4918-4072-9f6c-d7cfc96f1f48@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).