From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: David Christensen <drc@linux.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 2/2] powerpc: remove ehea driver references
Date: Wed, 20 May 2026 14:27:56 +0200 [thread overview]
Message-ID: <8ba30f1d-19ce-449a-966c-236fd6026c07@kernel.org> (raw)
In-Reply-To: <20260519224353.1282038-3-drc@linux.ibm.com>
Le 20/05/2026 à 00:43, David Christensen a écrit :
> [Vous ne recevez pas souvent de courriers de drc@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Follow-on cleanup after the removal of the IBM eHEA driver in commit
> XXXXXXXXXXXX ("net: ethernet: ibm: remove the ehea driver").
>
> Remove the CONFIG_IBM_EHEA entry from ppc64_defconfig and the obsolete
> comment in arch/powerpc/mm/mem.c that referenced the driver.
What do you mean by 'obsolete' ?
As far as I can see the commit is still valid, I can't see any other
module caller of function walk_system_ram_range().
The comment was introduced by commit 26b523356f49 ("powerpc: Drop
page_is_ram() and walk_system_ram_range()")
>
> Signed-off-by: David Christensen <drc@linux.ibm.com>
> ---
> arch/powerpc/configs/ppc64_defconfig | 1 -
> arch/powerpc/mm/mem.c | 4 ----
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig
> index 6316ca4df25d..b022d00708f4 100644
> --- a/arch/powerpc/configs/ppc64_defconfig
> +++ b/arch/powerpc/configs/ppc64_defconfig
> @@ -210,7 +210,6 @@ CONFIG_BNX2X=m
> CONFIG_CHELSIO_T1=m
> CONFIG_BE2NET=m
> CONFIG_IBMVETH=m
> -CONFIG_EHEA=m
> CONFIG_IBMVNIC=m
> CONFIG_E100=y
> CONFIG_E1000=y
> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> index 648d0c5602ec..1f5ad1a59d68 100644
> --- a/arch/powerpc/mm/mem.c
> +++ b/arch/powerpc/mm/mem.c
> @@ -370,10 +370,6 @@ int devmem_is_allowed(unsigned long pfn)
> }
> #endif /* CONFIG_STRICT_DEVMEM */
>
> -/*
> - * This is defined in kernel/resource.c but only powerpc needs to export it, for
> - * the EHEA driver. Drop this when drivers/net/ethernet/ibm/ehea is removed.
> - */
> EXPORT_SYMBOL_GPL(walk_system_ram_range);
As mentioned in the comment, the EXPORT_SYMBOL_GPL() has to be dropped
when drivers/net/ethernet/ibm/ehea is removed, which is now.
>
> #ifdef CONFIG_EXECMEM
> --
> 2.47.3
>
prev parent reply other threads:[~2026-05-20 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 22:43 [RFC PATCH net-next 0/2] net: remove the orphaned IBM eHEA driver David Christensen
2026-05-19 22:43 ` [RFC PATCH net-next 1/2] net: ethernet: ibm: remove the ehea driver David Christensen
2026-05-19 22:43 ` [RFC PATCH net-next 2/2] powerpc: remove ehea driver references David Christensen
2026-05-20 12:27 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba30f1d-19ce-449a-966c-236fd6026c07@kernel.org \
--to=chleroy@kernel.org \
--cc=davem@davemloft.net \
--cc=drc@linux.ibm.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox