Re: [PATCH net-next 1/3] net: phy: aquantia: report remote capabilities if link partner is Aquantia PHY

[Heiner Kallweit <hkallweit1@gmail.com>]

On 24.03.2019 02:01, Florian Fainelli wrote:
> 
> 
> On 3/23/2019 6:14 AM, Heiner Kallweit wrote:
>> If both link partners are Aquantia PHY's then additional information is
>> exchanged as part of the auto-negotiation. Report remote capabilities
>> if link partner is Aquantia PHY.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Petr is trying to introduce a link down reason, but it sounds like we
> should also have have a way to enhance the link up with information like
> the one you are providing here. It would also be nice if in the future,
> ethtool could display additional vendor specific information when the
> link is up. ethtool over netlink should facilitate that.
> 
Interesting idea. Most likely the available information will be quite
different, dependent on the vendor. So the PHY driver may have to
expose a list of items, each with a name and type.

> Thanks!
> 
Heiner