From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mike Frysinger" Subject: Re: [PATCH] SSB: make it depend on PCI Date: Thu, 6 Nov 2008 06:15:24 -0500 Message-ID: <8bd0f97a0811060315j7d11e1a7p257a4a1bea640f7b@mail.gmail.com> References: <1225965082-31462-1-git-send-email-vapier@gentoo.org> <1225969620.3619.204.camel@johannes.berg> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Mike Frysinger" , "Michael Buesch" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Johannes Berg" Return-path: Received: from rv-out-0506.google.com ([209.85.198.224]:40132 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753311AbYKFLPZ (ORCPT ); Thu, 6 Nov 2008 06:15:25 -0500 In-Reply-To: <1225969620.3619.204.camel@johannes.berg> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 6, 2008 at 06:07, Johannes Berg wrote: > On Thu, 2008-11-06 at 04:51 -0500, Mike Frysinger wrote: >> Since the SSB code requires PCI, set the Kconfig dependencies accordingly. >> Also tweak the menu display so that the menu does not show up at all if >> SSB is not possible. >> >> Signed-off-by: Mike Frysinger >> --- >> drivers/ssb/Kconfig | 7 ++++--- >> 1 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig >> index 307b1f6..f0a176a 100644 >> --- a/drivers/ssb/Kconfig >> +++ b/drivers/ssb/Kconfig >> @@ -1,10 +1,11 @@ >> -menu "Sonics Silicon Backplane" >> - >> config SSB_POSSIBLE >> bool >> - depends on HAS_IOMEM && HAS_DMA >> + depends on HAS_IOMEM && HAS_DMA && PCI > > This is incorrect. SSB is also used on embedded systems that do not use > PCI at all. while that may be the intent, it doesnt work today. drivers/ssb/main.c always includes linux/ssb/ssb.h linux/ssb/ssb.h always calls pci_dma_* functions arches that do not support PCI fail to build: CC drivers/ssb/main.o In file included from drivers/ssb/ssb_private.h:5, from drivers/ssb/main.c:12: include/linux/ssb/ssb.h: In function 'ssb_dma_mapping_error': include/linux/ssb/ssb.h:430: error: implicit declaration of function 'pci_dma_mapping_error' include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_for_cpu': include/linux/ssb/ssb.h:475: error: implicit declaration of function 'pci_dma_sync_single_for_cpu' include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_for_device': include/linux/ssb/ssb.h:493: error: implicit declaration of function 'pci_dma_sync_single_for_device' include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_range_for_cpu': include/linux/ssb/ssb.h:517: error: implicit declaration of function 'dma_sync_single_range_for_cpu' include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_range_for_device': include/linux/ssb/ssb.h:538: error: implicit declaration of function 'dma_sync_single_range_for_device' drivers/ssb/main.c: In function 'ssb_dma_set_mask': drivers/ssb/main.c:1183: error: implicit declaration of function 'dma_set_mask' make[1]: *** [drivers/ssb/main.o] Error 1 make: *** [drivers/ssb/main.o] Error 2 -mike