From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "David Miller" <davem@davemloft.net>
Cc: cooloney@kernel.org, jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, graf.yang@analog.com
Subject: Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
Date: Thu, 8 Jan 2009 14:01:49 -0500 [thread overview]
Message-ID: <8bd0f97a0901081101t6fdfa485rbd7ccc4e47691ddb@mail.gmail.com> (raw)
In-Reply-To: <20090108.105531.176161465.davem@davemloft.net>
On Thu, Jan 8, 2009 at 13:55, David Miller <davem@davemloft.net> wrote:
> From: Bryan Wu <cooloney@kernel.org>
>> +#define VLAN_ETHER_TYPE 0x8100
>
> Please use ETH_P_8021Q from linux/if_ether.h instead of inventing
> your own definition.
was a copy & paste due to not finding a better definition (3c59x.c)
>> + /* The legal length of the frame is increased to 1538 bytes */
>> + /*bfin_write_EMAC_VLAN2(VLAN_ETHER_TYPE);*/
>
> Please do not add code that is just going to be commented
> out and not used.
>
> Also, I disagree with the:
>
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
>
> conditional. Probably this part of the chip should be programmed
> unconditionally.
again, more of a copy & paste ... this is how a bunch of drivers are
doing it now ...
> We can get VLAN packets received and sent, using AF_PACKET
> sockets, for example. The chip should still respect those
> even if VLAN proper is not being utilized.
any tips on doing that ?
thanks for reviewing!
-mike
next prev parent reply other threads:[~2009-01-08 19:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 16:14 [PATCH 0/2] Blackfin EMAC driver updates Bryan Wu
2009-01-07 16:14 ` [PATCH 1/2] netdev: bfin_mac: enable bfin_mac net dev driver for BF51x Bryan Wu
2009-01-08 18:52 ` David Miller
2009-01-07 16:14 ` [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver Bryan Wu
2009-01-08 18:55 ` David Miller
2009-01-08 19:01 ` Mike Frysinger [this message]
2009-01-08 19:05 ` Mike Frysinger
2009-01-08 19:30 ` David Miller
2009-01-08 19:34 ` Mike Frysinger
2009-01-08 19:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0901081101t6fdfa485rbd7ccc4e47691ddb@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=graf.yang@analog.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).