From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "David Miller" <davem@davemloft.net>
Cc: cooloney@kernel.org, jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, graf.yang@analog.com
Subject: Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
Date: Thu, 8 Jan 2009 14:34:43 -0500 [thread overview]
Message-ID: <8bd0f97a0901081134gc5b6eb9h7f20dea146fc6cd0@mail.gmail.com> (raw)
In-Reply-To: <20090108.113009.263402475.davem@davemloft.net>
On Thu, Jan 8, 2009 at 14:30, David Miller wrote:
> From: "Mike Frysinger" <vapier
>> On Thu, Jan 8, 2009 at 14:01, Mike Frysinger wrote:
>> > On Thu, Jan 8, 2009 at 13:55, David Miller wrote:
>> >> We can get VLAN packets received and sent, using AF_PACKET
>> >> sockets, for example. The chip should still respect those
>> >> even if VLAN proper is not being utilized.
>> >
>> > any tips on doing that ?
>>
>> or rather, is there a driver or you two you can point out that is
>> doing this correctly ? the ones i looked at seemed to be doing it
>> like the patch we posted ...
>
> And I disagree with how those drivers are doing it :-)
>
> At least the programming of the chip to accept all packet
> types properly, VLAN or not, regardless of kernel config,
> is definitely IMHO the way to go.
i know on our side we all agree with you, we just didnt (dont) know
any better ;)
-mike
next prev parent reply other threads:[~2009-01-08 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 16:14 [PATCH 0/2] Blackfin EMAC driver updates Bryan Wu
2009-01-07 16:14 ` [PATCH 1/2] netdev: bfin_mac: enable bfin_mac net dev driver for BF51x Bryan Wu
2009-01-08 18:52 ` David Miller
2009-01-07 16:14 ` [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver Bryan Wu
2009-01-08 18:55 ` David Miller
2009-01-08 19:01 ` Mike Frysinger
2009-01-08 19:05 ` Mike Frysinger
2009-01-08 19:30 ` David Miller
2009-01-08 19:34 ` Mike Frysinger [this message]
2009-01-08 19:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0901081134gc5b6eb9h7f20dea146fc6cd0@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=graf.yang@analog.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).