From: Mike Frysinger <vapier.adi@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, a.beregalov@gmail.com,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 1/7] bfin_mac: fix build error due to net_device_ops convert
Date: Tue, 26 May 2009 19:14:16 -0400 [thread overview]
Message-ID: <8bd0f97a0905261614m269013ay9c800aa3060df387@mail.gmail.com> (raw)
In-Reply-To: <20090526.022927.34737131.davem@davemloft.net>
On Tue, May 26, 2009 at 05:29, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
> Date: Tue, 26 May 2009 05:29:09 -0400
>
>> The previous commit "convert to net_device_ops" broke the Blackfin MAC
>> driver as it declared the new structure before the function it used:
>> CC drivers/net/bfin_mac.o
>> drivers/net/bfin_mac.c:984: error: ‘bfin_mac_close’ undeclared here (not in a function)
>> make[1]: *** [drivers/net/bfin_mac.o] Error 1
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> I'll queue this up, thank you.
for 2.6.30 right ? :) this is a fix for an error introduced during
the 2.6.30 merge window ...
-mike
next prev parent reply other threads:[~2009-05-26 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 9:29 [PATCH 1/7] bfin_mac: fix build error due to net_device_ops convert Mike Frysinger
2009-05-26 9:29 ` David Miller
2009-05-26 23:14 ` Mike Frysinger [this message]
2009-05-27 3:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0905261614m269013ay9c800aa3060df387@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=a.beregalov@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).