Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB

[Mike Frysinger <vapier.adi@gmail.com>]

On Fri, May 29, 2009 at 05:04, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
>> From: Sonic Zhang <sonic.zhang@analog.com>
>>
>> Make sure data is really written into the registers before enabling DMA.
>> Otherwise, the EMAC DMA controller may transfer out a malformed packet.
>> This patch may also fix netperf bugs or scp bugs.
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
>> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>
> Instead of using this incredibly non-portable blackfin specific SSYNC
> thing

that doesnt make sense -- this is a completely non-portable Blackfin
specific driver.  everything in it uses Blackfin macros to access
Blackfin MMRs because this is a device that only exists on Blackfin
chips.

> why not read back a register from the device to ensure the
> register writes hit the chip just like other drivers do?

because that isnt how the Blackfin hardware works in general, and
certainly not how the DMA hardware works.

> If that doesn't work, enhance your commit message to describe (in
> detail) why SSYNC is the only way to make this work properly.

this is how it always is for all Blackfin on-chip registers, and the
hardware manual specifically dictates using SSYNC.
-mike