From: Mike Frysinger <vapier.adi@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, michael.hennerich@analog.com,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared
Date: Fri, 29 May 2009 06:49:42 -0400 [thread overview]
Message-ID: <8bd0f97a0905290349p6f52d170i3714cd3ec0c81817@mail.gmail.com> (raw)
In-Reply-To: <20090529.020122.110502272.davem@davemloft.net>
On Fri, May 29, 2009 at 05:01, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
>> From: Michael Hennerich <michael.hennerich@analog.com>
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>
> I'm not applying this.
>
> Either take the time to make this interrupt handler cope with shared
> interrupts (the most preferred) or take the time to write an
> excruciatingly long winded and explicit commit log message explaining
> why that's not possible.
>
> And I want the commit log message path to be as painful as possible so
> that you choose to fix this driver's IRQ handler to behave sanely
> instead. :-)
the hardware has a dedicated internal IRQ line for the Blackfin MAC.
it makes no sense to mark it as shared. there is nothing it could
possibly be shared with.
-mike
next prev parent reply other threads:[~2009-05-29 10:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 6:10 [PATCH 0/5] Blackfin MAC updates for 2.6.31 Mike Frysinger
2009-05-27 6:10 ` [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared Mike Frysinger
2009-05-29 9:01 ` David Miller
2009-05-29 10:49 ` Mike Frysinger [this message]
2009-05-29 10:53 ` [Uclinux-dist-devel] " David Miller
2009-05-29 11:12 ` Hennerich, Michael
2009-05-29 11:14 ` David Miller
2009-05-29 11:22 ` Mike Frysinger
2009-05-29 11:28 ` David Miller
2009-05-29 11:45 ` Mike Frysinger
2009-05-29 22:09 ` David Miller
2009-05-29 22:13 ` Mike Frysinger
2009-05-29 22:18 ` David Miller
2009-05-29 22:21 ` Mike Frysinger
2009-05-29 22:45 ` David Miller
2009-05-29 22:51 ` Mike Frysinger
2009-05-29 13:39 ` [PATCH 1/4 v2] netdev: bfin_mac: drop useless IRQF_SHARED from Blackfin EMAC interrupt Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-27 6:10 ` [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB Mike Frysinger
2009-05-29 9:04 ` David Miller
2009-05-29 10:46 ` Mike Frysinger
2009-05-29 10:52 ` David Miller
2009-05-29 11:20 ` Mike Frysinger
2009-05-29 11:27 ` David Miller
2009-05-29 11:42 ` Mike Frysinger
2009-05-31 2:42 ` Zhang, Sonic
2009-05-31 2:45 ` Zhang, Sonic
2009-05-29 13:40 ` [PATCH 2/4 v2] " Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-31 2:57 ` Zhang, Sonic
2009-05-27 6:10 ` [PATCH 3/5] netdev: bfin_mac: fix performance issue found by netperf Mike Frysinger
2009-05-29 9:05 ` David Miller
2009-05-29 13:41 ` [PATCH 3/4 v2] " Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-27 6:10 ` [PATCH 4/5] netdev: bfin_mac: add Blackfin MII bus to platform bus to allow DSA access Mike Frysinger
2009-05-29 9:09 ` David Miller
2009-05-27 6:10 ` [PATCH 5/5] netdev: bfin_mac: fix crash when unloading module Mike Frysinger
2009-05-29 9:10 ` David Miller
2009-05-29 11:47 ` [Uclinux-dist-devel] " Mike Frysinger
2009-05-29 13:41 ` [PATCH 4/4 v2] netdev: bfin_mac: add Blackfin MII bus to platform bus to allow DSA access Mike Frysinger
2009-05-29 22:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0905290349p6f52d170i3714cd3ec0c81817@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=davem@davemloft.net \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).