From: Mike Frysinger <vapier.adi@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Michael.Hennerich@analog.com, netdev@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared
Date: Fri, 29 May 2009 07:22:05 -0400 [thread overview]
Message-ID: <8bd0f97a0905290422x502d6006yb05ebe231b05e9bc@mail.gmail.com> (raw)
In-Reply-To: <20090529.041435.163819214.davem@davemloft.net>
On Fri, May 29, 2009 at 07:14, David Miller wrote:
> From: "Hennerich, Michael" <Michael.Hennerich@analog.com>
>> Our handler isn't prepared to handle such fake interrupts.
>> So two options:
>> 1) Set the proper IRQF flags.
>> 2) Fix the ISR to handle spurious interrupts.
>>
>> This patch chose option 1)
>
> And to go back to my initial reply, I'm saying to do the
> "right thing" and go with #2 if you can :-)
and the answer is that doesnt make sense. why implement extra over
head in an interrupt handler to support an operating mode the hardware
can never support. if the IRQ could actually be shared, then sure, we
should check things. but it cant, so you're suggesting we waste time
in an IRQ handler for absolutely no gain.
-mike
next prev parent reply other threads:[~2009-05-29 11:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 6:10 [PATCH 0/5] Blackfin MAC updates for 2.6.31 Mike Frysinger
2009-05-27 6:10 ` [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared Mike Frysinger
2009-05-29 9:01 ` David Miller
2009-05-29 10:49 ` [Uclinux-dist-devel] " Mike Frysinger
2009-05-29 10:53 ` David Miller
2009-05-29 11:12 ` Hennerich, Michael
2009-05-29 11:14 ` David Miller
2009-05-29 11:22 ` Mike Frysinger [this message]
2009-05-29 11:28 ` David Miller
2009-05-29 11:45 ` Mike Frysinger
2009-05-29 22:09 ` David Miller
2009-05-29 22:13 ` Mike Frysinger
2009-05-29 22:18 ` David Miller
2009-05-29 22:21 ` Mike Frysinger
2009-05-29 22:45 ` David Miller
2009-05-29 22:51 ` Mike Frysinger
2009-05-29 13:39 ` [PATCH 1/4 v2] netdev: bfin_mac: drop useless IRQF_SHARED from Blackfin EMAC interrupt Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-27 6:10 ` [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB Mike Frysinger
2009-05-29 9:04 ` David Miller
2009-05-29 10:46 ` Mike Frysinger
2009-05-29 10:52 ` David Miller
2009-05-29 11:20 ` Mike Frysinger
2009-05-29 11:27 ` David Miller
2009-05-29 11:42 ` Mike Frysinger
2009-05-31 2:42 ` Zhang, Sonic
2009-05-31 2:45 ` Zhang, Sonic
2009-05-29 13:40 ` [PATCH 2/4 v2] " Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-31 2:57 ` Zhang, Sonic
2009-05-27 6:10 ` [PATCH 3/5] netdev: bfin_mac: fix performance issue found by netperf Mike Frysinger
2009-05-29 9:05 ` David Miller
2009-05-29 13:41 ` [PATCH 3/4 v2] " Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-27 6:10 ` [PATCH 4/5] netdev: bfin_mac: add Blackfin MII bus to platform bus to allow DSA access Mike Frysinger
2009-05-29 9:09 ` David Miller
2009-05-27 6:10 ` [PATCH 5/5] netdev: bfin_mac: fix crash when unloading module Mike Frysinger
2009-05-29 9:10 ` David Miller
2009-05-29 11:47 ` [Uclinux-dist-devel] " Mike Frysinger
2009-05-29 13:41 ` [PATCH 4/4 v2] netdev: bfin_mac: add Blackfin MII bus to platform bus to allow DSA access Mike Frysinger
2009-05-29 22:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0905290422x502d6006yb05ebe231b05e9bc@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).