From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subash Abhinov Kasiviswanathan Subject: Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate Date: Wed, 03 Jan 2018 15:45:29 -0700 Message-ID: <8bd76556945c563980a72009f9c86a13@codeaurora.org> References: <1515015787-6713-1-git-send-email-subashab@codeaurora.org> <1515015787-6713-6-git-send-email-subashab@codeaurora.org> <1515016918.131759.2.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, lkp@intel.com To: Eric Dumazet Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47868 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbeACWpa (ORCPT ); Wed, 3 Jan 2018 17:45:30 -0500 In-Reply-To: <1515016918.131759.2.camel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: >> + sk_pacing_shift_update(skb->sk, 8); > > Well... Please tell us why this is needed in this driver. > > This interface is meant for wifi aggregation, not to work around some > strange ethernet drivers designs. Hi Eric The real device over which the rmnet devices are installed also aggregate multiple IP packets and sends them as a single large aggregate frame to the hardware. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project