From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "andrew@lunn.ch" <andrew@lunn.ch>
Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>,
"wei.fang@nxp.com" <wei.fang@nxp.com>,
"robh@kernel.org" <robh@kernel.org>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"frank.li@nxp.com" <frank.li@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"shenwei.wang@nxp.com" <shenwei.wang@nxp.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH net-next 0/2] net: fec: support RX flushing via fsl,rx-flush-queues
Date: Fri, 14 Aug 2026 14:21:46 +0000 [thread overview]
Message-ID: <8c0cd8dec1a38f1d50e056666ef9f22637a86953.camel@siemens.com> (raw)
In-Reply-To: <d40f618a-8c04-42a2-904c-00cdb14ff988@lunn.ch>
Thanks for the quick feedback, Andrew!
On Fri, 2026-08-14 at 15:56 +0200, Andrew Lunn wrote:
> > The FEC/ENET controller can flush frames that get stuck at the head of the
> > RX FIFO because their destination ring has no empty buffer descriptor
> > (RxBD[E] clear or ENET_RDARn not set). Without flushing, such a frame blocks
> > the FIFO and stalls reception on all queues; with flushing enabled the
> > offending frame is discarded instead. Flushing is configured per RX queue
> > through the RX_FLUSHn bits of the QOS Scheme register (FEC_QOS_SCHEME).
> >
> > This series adds a device tree property, fsl,rx-flush-queues, listing the RX
> > queues for which flushing should be enabled, and programs the corresponding
> > RX_FLUSHn bits.
>
> DT described hardware, not policy for how hardware is configured.
>
> Maybe use an ethtool private flags?
Makes sense to me, I'll rework!
--
Alexander Sverdlin
Siemens AG
www.siemens.com
prev parent reply other threads:[~2026-08-14 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 9:08 [PATCH net-next 0/2] net: fec: support RX flushing via fsl,rx-flush-queues A. Sverdlin
2026-08-14 9:09 ` [PATCH net-next 1/2] dt-bindings: net: fsl,fec: add fsl,rx-flush-queues A. Sverdlin
2026-08-14 9:09 ` [PATCH net-next 2/2] net: fec: support receive flushing via fsl,rx-flush-queues A. Sverdlin
2026-08-14 10:31 ` Sverdlin, Alexander
2026-08-14 13:56 ` [PATCH net-next 0/2] net: fec: support RX " Andrew Lunn
2026-08-14 14:21 ` Sverdlin, Alexander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0cd8dec1a38f1d50e056666ef9f22637a86953.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox