From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next 00/10] Cleanups, minor additions & fixes for HNS3 driver Date: Fri, 28 Sep 2018 11:56:13 -0700 Message-ID: <8cc644da-f6f2-9dd4-8f97-b1fa6d9deae7@gmail.com> References: <20180926182840.28392-1-salil.mehta@huawei.com> <20180928.103826.486456665561471777.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com, mehta.salil@opnsrc.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com To: David Miller , salil.mehta@huawei.com Return-path: In-Reply-To: <20180928.103826.486456665561471777.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/28/2018 10:38 AM, David Miller wrote: > From: Salil Mehta > Date: Wed, 26 Sep 2018 19:28:30 +0100 > >> This patch-set contains cleans-ups, minor changes and fixes to the HNS3 driver. > > Series applied, thank you. > Something seems wrong # git grep -n HNS3_SELF_TEST_TYPE_NUM drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278: int st_param[HNS3_SELF_TEST_TYPE_NUM][2]; drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:316: for (i = 0; i < HNS3_SELF_TEST_TYPE_NUM; i++) { drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function 'hns3_self_test': drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: error: 'HNS3_SELF_TEST_TYPE_NUM' undeclared (first use in this function) drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:6: error: unused variable 'st_param' [-Werror=unused-variable]