From: David Ahern <dsahern@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>,
Davide Caratti <dcaratti@redhat.com>,
Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding
Date: Sat, 7 Jul 2018 08:51:13 -0600 [thread overview]
Message-ID: <8cf9d2c6-4291-3902-7bb6-15710cf4e6bf@gmail.com> (raw)
In-Reply-To: <CADvbK_efWXba42rMcdSwCDrOtiPreu-u6ZPkg0BgSrgBqXcjFg@mail.gmail.com>
On 7/6/18 3:50 AM, Xin Long wrote:
>>> Try this:
>>>
>>> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
>>> index b21833651394..e46cdd310e5f 100644
>>> --- a/net/ipv4/fib_frontend.c
>>> +++ b/net/ipv4/fib_frontend.c
>>> @@ -300,6 +300,7 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb)
>>> if (!ipv4_is_zeronet(ip_hdr(skb)->saddr)) {
>>> struct flowi4 fl4 = {
>>> .flowi4_iif = LOOPBACK_IFINDEX,
>>> + .flowi4_oif = l3mdev_master_ifindex_rcu(dev),
>>> .daddr = ip_hdr(skb)->saddr,
>>> .flowi4_tos = RT_TOS(ip_hdr(skb)->tos),
>>> .flowi4_scope = scope,
> If this patch can be applied, I would be able to make a proper selftest like:
Forgot to send the patch yesterday. Will do so sometime this weekend.
next prev parent reply other threads:[~2018-07-07 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 6:30 [PATCHv2 net-next 0/2] route: add support and selftests for directed broadcast forwarding Xin Long
2018-07-02 6:30 ` [PATCHv2 net-next 1/2] route: add support " Xin Long
2018-07-02 6:30 ` [PATCHv2 net-next 2/2] selftests: add a selftest " Xin Long
2018-07-02 15:12 ` David Ahern
2018-07-03 11:36 ` Xin Long
2018-07-03 19:23 ` David Ahern
2018-07-04 17:56 ` Xin Long
2018-07-04 18:31 ` David Ahern
2018-07-04 18:36 ` David Ahern
2018-07-05 7:57 ` Xin Long
2018-07-05 13:18 ` David Ahern
2018-07-05 14:07 ` Xin Long
2018-07-06 9:50 ` Xin Long
2018-07-07 14:51 ` David Ahern [this message]
2018-07-04 20:39 ` Ido Schimmel
2018-07-05 8:21 ` Xin Long
2018-07-05 15:38 ` Xin Long
2018-07-02 9:57 ` [PATCHv2 net-next 1/2] route: add support " Davide Caratti
2018-07-02 15:05 ` David Ahern
2018-07-03 11:38 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cf9d2c6-4291-3902-7bb6-15710cf4e6bf@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=idosch@idosch.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).