From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed
 broadcast forwarding
Date: Sat, 7 Jul 2018 08:51:13 -0600
Message-ID: <8cf9d2c6-4291-3902-7bb6-15710cf4e6bf@gmail.com>
References: <cover.1530512974.git.lucien.xin@gmail.com>
 <62ecbcf0c905dde3bfde51cd260e2f7c59e21028.1530512974.git.lucien.xin@gmail.com>
 <03b43b2dbda208510514082b2bd94643c3a6580c.1530512974.git.lucien.xin@gmail.com>
 <fc462436-af77-2c95-ec79-6cc418ef126e@gmail.com>
 <CADvbK_ciwsQuJ3Ep0_oFzmFSAPGMB9vjB=KXZ=feG5X1M=oZnw@mail.gmail.com>
 <5e5f7edf-1313-cfef-9005-b05ec9051b25@gmail.com>
 <CADvbK_c6pdnHuKd_aDG3REWvGRx5AtGH2YO90tyRvcWesBDzPw@mail.gmail.com>
 <2d75173b-b6f2-974c-32c2-df29bffd6a6a@gmail.com>
 <CADvbK_fsFHuW4gvtpSZ-A8F12PXaMX8YGGKmhsMy3L_KTZt-8Q@mail.gmail.com>
 <df1c3df6-bd68-8a97-df36-ab3fa14d2bcb@gmail.com>
 <CADvbK_fcgH7OM2Z8Wsvz=7svt=UZ6+QfE2Yw1+J7E9RXCVm1PQ@mail.gmail.com>
 <CADvbK_efWXba42rMcdSwCDrOtiPreu-u6ZPkg0BgSrgBqXcjFg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>,
        Davide Caratti <dcaratti@redhat.com>,
        Ido Schimmel <idosch@idosch.org>
To: Xin Long <lucien.xin@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f66.google.com ([209.85.160.66]:40331 "EHLO
        mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753173AbeGGOvQ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 7 Jul 2018 10:51:16 -0400
Received: by mail-pl0-f66.google.com with SMTP id t6-v6so4132086plo.7
        for <netdev@vger.kernel.org>; Sat, 07 Jul 2018 07:51:16 -0700 (PDT)
In-Reply-To: <CADvbK_efWXba42rMcdSwCDrOtiPreu-u6ZPkg0BgSrgBqXcjFg@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 7/6/18 3:50 AM, Xin Long wrote:
>>> Try this:
>>>
>>> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
>>> index b21833651394..e46cdd310e5f 100644
>>> --- a/net/ipv4/fib_frontend.c
>>> +++ b/net/ipv4/fib_frontend.c
>>> @@ -300,6 +300,7 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb)
>>>         if (!ipv4_is_zeronet(ip_hdr(skb)->saddr)) {
>>>                 struct flowi4 fl4 = {
>>>                         .flowi4_iif = LOOPBACK_IFINDEX,
>>> +                       .flowi4_oif = l3mdev_master_ifindex_rcu(dev),
>>>                         .daddr = ip_hdr(skb)->saddr,
>>>                         .flowi4_tos = RT_TOS(ip_hdr(skb)->tos),
>>>                         .flowi4_scope = scope,
> If this patch can be applied, I would be able to make a proper selftest like:

Forgot to send the patch yesterday. Will do so sometime this weekend.