From: "liujian (CE)" <liujian56@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next 0/2] Add helper functions to parse netlink msg of ip_tunnel
Date: Wed, 28 Sep 2022 03:34:51 +0000 [thread overview]
Message-ID: <8d13b0eec28745a59533674a64c9cf48@huawei.com> (raw)
In-Reply-To: <20220927075855.7c09921b@kernel.org>
> -----Original Message-----
> From: Jakub Kicinski [mailto:kuba@kernel.org]
> Sent: Tuesday, September 27, 2022 10:59 PM
> To: liujian (CE) <liujian56@huawei.com>
> Cc: davem@davemloft.net; yoshfuji@linux-ipv6.org; dsahern@kernel.org;
> edumazet@google.com; pabeni@redhat.com; netdev@vger.kernel.org
> Subject: Re: [PATCH net-next 0/2] Add helper functions to parse netlink msg
> of ip_tunnel
>
> On Mon, 26 Sep 2022 21:19:42 +0800 Liu Jian wrote:
> > Add helper functions to parse netlinkmsg of ip_tunnel
> >
> > Liu Jian (2):
> > net: Add helper function to parse netlink msg of ip_tunnel_encap
> > net: Add helper function to parse netlink msg of ip_tunnel_parm
> >
> > include/net/ip_tunnels.h | 66
> ++++++++++++++++++++++++++++++++++++++++
> > net/ipv4/ipip.c | 62 ++-----------------------------------
> > net/ipv6/ip6_tunnel.c | 37 ++--------------------
> > net/ipv6/sit.c | 65 ++-------------------------------------
>
> Do they need to be in a header file? Could you put them in
> net/ipv4/ip_tunnel.c or net/ipv4/ip_tunnel_core.c instead?
The v2 version has been sent. Thanks for your review.
prev parent reply other threads:[~2022-09-28 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 13:19 [PATCH net-next 0/2] Add helper functions to parse netlink msg of ip_tunnel Liu Jian
2022-09-26 13:19 ` [PATCH net-next 1/2] net: Add helper function to parse netlink msg of ip_tunnel_encap Liu Jian
2022-09-26 13:19 ` [PATCH net-next 2/2] net: Add helper function to parse netlink msg of ip_tunnel_parm Liu Jian
2022-09-27 14:58 ` [PATCH net-next 0/2] Add helper functions to parse netlink msg of ip_tunnel Jakub Kicinski
2022-09-28 3:34 ` liujian (CE) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d13b0eec28745a59533674a64c9cf48@huawei.com \
--to=liujian56@huawei.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).