From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
tariqt@nvidia.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] mlx4: use READ_ONCE/WRITE_ONCE for ring indexes
Date: Wed, 12 Apr 2023 09:07:13 +0300 [thread overview]
Message-ID: <8d13ca06-3183-8511-62fd-ae267a9b4699@gmail.com> (raw)
In-Reply-To: <20230412015038.674023-4-kuba@kernel.org>
On 12/04/2023 4:50, Jakub Kicinski wrote:
> Eric points out that we should make sure that ring index updates
> are wrapped in the appropriate READ_ONCE/WRITE_ONCE macros.
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: tariqt@nvidia.com
> CC: linux-rdma@vger.kernel.org
> ---
> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks!
next prev parent reply other threads:[~2023-04-12 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 1:50 [PATCH net-next v2 0/3] net: use READ_ONCE/WRITE_ONCE for ring index accesses Jakub Kicinski
2023-04-12 1:50 ` [PATCH net-next v2 1/3] net: docs: update the sample code in driver.rst Jakub Kicinski
2023-04-12 1:50 ` [PATCH net-next v2 2/3] bnxt: use READ_ONCE/WRITE_ONCE for ring indexes Jakub Kicinski
2023-04-12 1:59 ` Michael Chan
2023-04-12 8:15 ` David Laight
2023-04-13 11:38 ` Paolo Abeni
2023-04-13 14:20 ` David Laight
2023-04-12 1:50 ` [PATCH net-next v2 3/3] mlx4: " Jakub Kicinski
2023-04-12 6:07 ` Tariq Toukan [this message]
2023-04-13 11:50 ` [PATCH net-next v2 0/3] net: use READ_ONCE/WRITE_ONCE for ring index accesses patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d13ca06-3183-8511-62fd-ae267a9b4699@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).