From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] bnxt_en: enable PTM function
Date: Thu, 6 Aug 2026 21:45:34 +0100 [thread overview]
Message-ID: <8d21f245-abde-47b8-a7c8-b62a1ada6200@linux.dev> (raw)
In-Reply-To: <CACKFLimm+_nUX4s5MoNw+cavA6pXr+1ZDpRO+4Fya-ZBfzhreQ@mail.gmail.com>
On 06.08.2026 21:35, Michael Chan wrote:
> On Thu, Aug 6, 2026 at 1:22 PM Vadim Fedorenko
> <vadim.fedorenko@linux.dev> wrote:
>>
>> The patch mentioned in Fixes missed one main point of implementing
>> proper PTM support. To make it fully operational it has to be explicitly
>> enabled. Add missing call in probe callback and disable it in teardown
>> callback.
>
> We were actually discussing this internally just a few weeks ago. I
> think the FW always enables it and that's why pci_enable_ptm() is not
> strictly required. I'll let Pavan comment on this further. Thanks.
In my test even though firmware was acting as requestor, pcie_ptm_enabled()
returns false and disables setup of getcrosststamp callback. This happens
because kernel doesn't know that PTM is enabled.
next prev parent reply other threads:[~2026-08-06 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 20:18 [PATCH net] bnxt_en: enable PTM function Vadim Fedorenko
2026-08-06 20:35 ` Michael Chan
2026-08-06 20:45 ` Vadim Fedorenko [this message]
2026-08-07 12:51 ` Pavan Chebbi
2026-08-07 14:00 ` Vadim Fedorenko
2026-08-07 16:13 ` Pavan Chebbi
2026-08-07 19:27 ` Vadim Fedorenko
2026-08-08 4:39 ` Pavan Chebbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d21f245-abde-47b8-a7c8-b62a1ada6200@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox