From: Andrew Lunn <andrew@lunn.ch>
To: Shubham Das <shubham.das@intel.com>
Cc: netdev@vger.kernel.org, maxime.chevallier@bootlin.com,
alexander.duyck@gmail.com, lee@trager.us, siddaraju.dh@intel.com,
balaji.chintalapalle@intel.com, dasshubhamk@gmail.com,
magnus.k.lindberg@ericsson.com, jonas.wirandi@ericsson.com
Subject: Re: [RFC net-next 1/2] ethtool: add interface capabilities query (intf-caps-get)
Date: Wed, 30 Sep 2026 15:53:03 +0200 [thread overview]
Message-ID: <8d44e2b3-532a-4c82-9458-40ddae333593@lunn.ch> (raw)
In-Reply-To: <20260930132151.932792-2-shubham.das@intel.com>
> extern const struct nla_policy ethnl_mse_get_policy[ETHTOOL_A_MSE_HEADER + 1];
> +extern const struct nla_policy
> +ethnl_intf_caps_get_policy[ETHTOOL_A_INTF_CAPS_HEADER + 1];
That is odd wrapping. As far as i can see, no other declaration is
wrapped like this. Is this because of the 80 character rules? It is
better to keep with the existing coding style.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-09-30 13:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 13:21 [RFC net-next 0/2] ethtool: add interface caps and PHY tests Shubham Das
2026-09-30 13:21 ` [RFC net-next 1/2] ethtool: add interface capabilities query (intf-caps-get) Shubham Das
2026-09-30 13:53 ` Andrew Lunn [this message]
2026-10-05 4:10 ` Das, Shubham
2026-09-30 13:21 ` [RFC net-next 2/2] ethtool: add PHY test framework Shubham Das
2026-09-30 13:21 ` [RFC ethtool 0/2] add interface caps and PHY tests Shubham Das
2026-09-30 13:21 ` [RFC ethtool 1/2] ethtool: Add interface capability get support Shubham Das
2026-09-30 13:21 ` [RFC ethtool 2/2] ethtool: Add PHY test and BERT support Shubham Das
2026-09-30 13:58 ` [RFC net-next 0/2] ethtool: add interface caps and PHY tests Andrew Lunn
2026-10-05 4:13 ` Das, Shubham
2026-10-05 13:43 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d44e2b3-532a-4c82-9458-40ddae333593@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.duyck@gmail.com \
--cc=balaji.chintalapalle@intel.com \
--cc=dasshubhamk@gmail.com \
--cc=jonas.wirandi@ericsson.com \
--cc=lee@trager.us \
--cc=magnus.k.lindberg@ericsson.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=shubham.das@intel.com \
--cc=siddaraju.dh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox