From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0850C28CC5 for ; Fri, 31 May 2019 16:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CBC526C5B for ; Fri, 31 May 2019 16:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IVKQwKKC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbfEaQoO (ORCPT ); Fri, 31 May 2019 12:44:14 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:47024 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbfEaQoN (ORCPT ); Fri, 31 May 2019 12:44:13 -0400 Received: by mail-pf1-f193.google.com with SMTP id y11so6510684pfm.13; Fri, 31 May 2019 09:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hde30i5KCYUZxt8+LFmVtC1WVvT0nk/YtPMpuB6CEbA=; b=IVKQwKKCEaYWIV/WiSav0v/Wlpap4oD0zGzl0QwBbCWLzd8Pc+hrDcSEW9g/vCDMN+ psSUJjq9HbCVDuCXibv8w+1iX5TlNq0uhibinv1KmAhrZHUa1SQbgBWc6R9HvA5OBkN9 1zJIZnsRU0b5oMffR9aN8AmRvATPdmwn6zGS1NZKLgE+3duCj8c4ytlIxsmtJCCAov4M RJXuNIHY4bBWaNaXBC0AKDOd+nKToapdpLyW28J/aPVOGaW73pOrkqvNwhiC4ENg3eve XnjtvEqIXtWxwNrqh2vt4l3lavjjCLOk3YRptyFj6I9DIZz5GOgYolvmQYqgf7b70PEZ ZeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=hde30i5KCYUZxt8+LFmVtC1WVvT0nk/YtPMpuB6CEbA=; b=f0S0yYH/8RgkaqYc4Difxhljt2gGgGLWy5BATyx0nXg8klo+L/RbT3VKYjR5I7KZTv AzFt1ItkrTNToXYTL9qHWJ9iDkbJA2ZuAKlOMzcAcg0K/cJ6HtdOl/1XTL924ugyQVmh krgbs+wrivd00T5w8SzPunn91BzY59y8SyxpHQ/O9oJ9NBFuJU+L2E1/BqKLZjRk70W9 D79dGBOaNm/ly1Wqt9D7CTu6EGbLrdJoJt7sZShikYd4nOJKUkc/MRaz09OanL3QJBBZ 2520rv7M+z+ABtYFY+D3Quh+JamjUW6BDg8udltlsdgrg6+1GGqsj906FaBXSiCapv6I fvgQ== X-Gm-Message-State: APjAAAXjKbXLr18lEk+FLLYyhwuSOVnlC1JScpndSjuSb2HPoTDp1J4c NcQMjZ6snm1MRJKI/X7zDiY= X-Google-Smtp-Source: APXvYqxJnkjQTm4I7zT8EfbSE+xlUzLne6dIYWi2Vvruqcj6XwNkwxT8gxI/E2U8RPwPbR71/DFEpg== X-Received: by 2002:a62:b50c:: with SMTP id y12mr5722026pfe.171.1559321052494; Fri, 31 May 2019 09:44:12 -0700 (PDT) Received: from [10.67.49.123] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id n2sm5845502pgp.27.2019.05.31.09.44.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 09:44:11 -0700 (PDT) Subject: Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0 To: Vivien Didelot , Nikita Yushchenko Cc: Andrew Lunn , "David S. Miller" , Heiner Kallweit , =?UTF-8?Q?Marek_Beh=c3=ban?= , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy References: <20190531073514.2171-1-nikita.yoush@cogentembedded.com> <20190531103105.GE23464@t480s.localdomain> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <8d5070ac-1f31-cff0-5a5b-2134c7894b3f@gmail.com> Date: Fri, 31 May 2019 09:44:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190531103105.GE23464@t480s.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 5/31/19 7:31 AM, Vivien Didelot wrote: > Hi Nikita, > > On Fri, 31 May 2019 10:35:14 +0300, Nikita Yushchenko wrote: >> When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error >> message is logged: >> >> failed to kill vid 0081/0 for device eth_cu_1000_4 >> >> This is caused by call from __vlan_vid_del() with vin set to zero, over >> call chain this results into _mv88e6xxx_port_vlan_del() called with >> vid=0, and mv88e6xxx_vtu_get() called from there returns -EINVAL. >> >> On symmetric path moving port up, call goes through >> mv88e6xxx_port_vlan_prepare() that calls mv88e6xxx_port_check_hw_vlan() >> that returns -EOPNOTSUPP for zero vid. >> >> This patch changes mv88e6xxx_vtu_get() to also return -EOPNOTSUPP for >> zero vid, then this error code is explicitly cleared in >> dsa_slave_vlan_rx_kill_vid() and error message is no longer logged. >> >> Signed-off-by: Nikita Yushchenko >> --- >> drivers/net/dsa/mv88e6xxx/chip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c >> index 28414db979b0..6b77fde5f0e4 100644 >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -1392,7 +1392,7 @@ static int mv88e6xxx_vtu_get(struct mv88e6xxx_chip *chip, u16 vid, >> int err; >> >> if (!vid) >> - return -EINVAL; >> + return -EOPNOTSUPP; >> >> entry->vid = vid - 1; >> entry->valid = false; > > I'm not sure that I like the semantic of it, because the driver can actually > support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would avoid > calling the port_vlan_del() ops for VID 0, directly into the upper DSA layer. > > Florian, Andrew, wouldn't the following patch be more adequate? See my comment about the usage of VLAN ID == 0 with non mv88e6xxx switches this would break VLAN filtering/isolation for non bridged port. > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 1e2ae9d59b88..80f228258a92 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -1063,6 +1063,10 @@ static int dsa_slave_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, > struct bridge_vlan_info info; > int ret; > > + /* VID 0 has a special meaning and is never programmed in hardware */ > + if (!vid) > + return 0; > + > /* Check for a possible bridge VLAN entry now since there is no > * need to emulate the switchdev prepare + commit phase. > */ > > > Thanks, > Vivien > -- Florian