From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1971163A3 for ; Fri, 11 Aug 2023 09:30:51 +0000 (UTC) Received: from out-108.mta0.migadu.com (out-108.mta0.migadu.com [91.218.175.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1364A2D5B for ; Fri, 11 Aug 2023 02:30:49 -0700 (PDT) Message-ID: <8d52ab61-e532-0ef8-4227-ea1ab469f4cb@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691746247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JZUyYZ+8XJKTUbZKK1DdFQCGq8cNFYsFwnq8YwkTDfs=; b=GxU9QjIRAA/RVyaUj1LaqCJKMOW/MhFBn7HuPQpEBaRlc0/os4PZM4k8PctvTdV7pEAoit sd1dFvUpsQz3nw3NVmf7QCM1FNKzCmMtDo//9eCKoYRlJZ/7qlzkuUvSisYCAl8riGEODZ YMhbjwuujNIc9Px/jlE4XGJ9iWNOP5U= Date: Fri, 11 Aug 2023 10:30:43 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v3 6/9] ice: add admin commands to access cgu configuration Content-Language: en-US To: Jakub Kicinski Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org References: <20230809214027.556192-1-vadim.fedorenko@linux.dev> <20230809214027.556192-7-vadim.fedorenko@linux.dev> <20230810192102.2932d58f@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230810192102.2932d58f@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 11/08/2023 03:21, Jakub Kicinski wrote: > On Wed, 9 Aug 2023 22:40:24 +0100 Vadim Fedorenko wrote: >> From: Arkadiusz Kubalewski >> >> Add firmware admin command to access clock generation unit >> configuration, it is required to enable Extended PTP and SyncE features >> in the driver. >> Add definitions of possible hardware variations of input and output pins >> related to clock generation unit and functions to access the data. > > Doesn't build, but hold off a little with reposting, please hopefully > I'll have more time tomorrow to review. Yeah, we've found the issue already and Arkadiusz has prepared a patch to fix it. I can do the repost once you are ok to review.