From: David Ahern <dsahern@gmail.com>
To: Serhey Popovych <serhe.popovych@gmail.com>, netdev@vger.kernel.org
Cc: jbenc@redhat.com, pabeni@redhat.com, u9012063@gmail.com,
julien@cumulusnetworks.com
Subject: Re: [PATCH iproute2-next v2 0/2] ip/tunnel: Unify collect metadata handling
Date: Wed, 24 Jan 2018 11:05:17 -0700 [thread overview]
Message-ID: <8d5837c5-d216-4426-f481-a27b90de33e0@gmail.com> (raw)
In-Reply-To: <1516641826-23965-1-git-send-email-serhe.popovych@gmail.com>
On 1/22/18 10:23 AM, Serhey Popovych wrote:
> With this series I want to unify collect metadata
> handling in tunnels:
>
> 1) Use "external" name for JSON and non-JSON output.
>
> Do not *print* any options when tunnel in
> collect metadata mode: gre6 already do
> this, so just apply to others.
>
> 2) Do not *add* any attributes when configuring
> gre tunnel in collect metadata mode.
>
> Other tunnels (e.g. gre6, iptnl, ip6tnl)
> alredy do that.
>
> This is next step in ipv4 and ipv6 modules
> unification to prepare for merge in the future.
>
> Any comments, suggestions and criticism as always
> welcome.
>
> v2
> For all tunnels implementing collect metadata
> use "external" keyword for both JSON. Thanks
> to Jiri Benc for detailed explanation.
>
Series applied to iproute2-next
prev parent reply other threads:[~2018-01-24 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 17:23 [PATCH iproute2-next v2 0/2] ip/tunnel: Unify collect metadata handling Serhey Popovych
2018-01-22 17:23 ` [PATCH iproute2-next v2 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata Serhey Popovych
2018-01-22 17:23 ` [PATCH iproute2-next v2 2/2] gre/gre6: Unify attribute addition to netlink buffer Serhey Popovych
2018-01-24 18:05 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5837c5-d216-4426-f481-a27b90de33e0@gmail.com \
--to=dsahern@gmail.com \
--cc=jbenc@redhat.com \
--cc=julien@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=serhe.popovych@gmail.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).