From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next v2 0/2] ip/tunnel: Unify collect metadata handling Date: Wed, 24 Jan 2018 11:05:17 -0700 Message-ID: <8d5837c5-d216-4426-f481-a27b90de33e0@gmail.com> References: <1516641826-23965-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: jbenc@redhat.com, pabeni@redhat.com, u9012063@gmail.com, julien@cumulusnetworks.com To: Serhey Popovych , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f51.google.com ([74.125.83.51]:44500 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964826AbeAXSFU (ORCPT ); Wed, 24 Jan 2018 13:05:20 -0500 Received: by mail-pg0-f51.google.com with SMTP id m20so3233159pgc.11 for ; Wed, 24 Jan 2018 10:05:20 -0800 (PST) In-Reply-To: <1516641826-23965-1-git-send-email-serhe.popovych@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/22/18 10:23 AM, Serhey Popovych wrote: > With this series I want to unify collect metadata > handling in tunnels: > > 1) Use "external" name for JSON and non-JSON output. > > Do not *print* any options when tunnel in > collect metadata mode: gre6 already do > this, so just apply to others. > > 2) Do not *add* any attributes when configuring > gre tunnel in collect metadata mode. > > Other tunnels (e.g. gre6, iptnl, ip6tnl) > alredy do that. > > This is next step in ipv4 and ipv6 modules > unification to prepare for merge in the future. > > Any comments, suggestions and criticism as always > welcome. > > v2 > For all tunnels implementing collect metadata > use "external" keyword for both JSON. Thanks > to Jiri Benc for detailed explanation. > Series applied to iproute2-next