Re: [PATCH net-next v17 03/14] net: Make net_hwtstamp_validate accessible

[Jacob Keller <jacob.e.keller@intel.com>]

On 7/9/2024 6:53 AM, Kory Maincent wrote:
> Make the net_hwtstamp_validate function accessible in prevision to use
> it from ethtool to validate the hwtstamp configuration before setting it.
> 
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v8:
> - New patch
> 
> Change in v10:
> - Remove export symbol as ethtool can't be built as a module.
> - Move the declaration to net/core/dev.h instead of netdevice.h
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  net/core/dev.h       | 1 +
>  net/core/dev_ioctl.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/dev.h b/net/core/dev.h
> index 9d4ceaf9bdc0..df085c3e510c 100644
> --- a/net/core/dev.h
> +++ b/net/core/dev.h
> @@ -189,5 +189,6 @@ int dev_set_hwtstamp_phylib(struct net_device *dev,
>  			    struct netlink_ext_ack *extack);
>  int dev_get_hwtstamp_phylib(struct net_device *dev,
>  			    struct kernel_hwtstamp_config *cfg);
> +int net_hwtstamp_validate(const struct kernel_hwtstamp_config *cfg);
>  
>  #endif
> diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
> index b8cf8c55fa2d..6aaa8326bf8f 100644
> --- a/net/core/dev_ioctl.c
> +++ b/net/core/dev_ioctl.c
> @@ -184,7 +184,7 @@ static int dev_ifsioc_locked(struct net *net, struct ifreq *ifr, unsigned int cm
>  	return err;
>  }
>  
> -static int net_hwtstamp_validate(const struct kernel_hwtstamp_config *cfg)
> +int net_hwtstamp_validate(const struct kernel_hwtstamp_config *cfg)
>  {
>  	enum hwtstamp_tx_types tx_type;
>  	enum hwtstamp_rx_filters rx_filter;
>