From: Pavel Skripkin <paskripkin@gmail.com>
To: Stefan Schmidt <stefan@datenfreihafen.org>,
alex.aring@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ieee802154: atusb: move to new USB API
Date: Wed, 5 Jan 2022 23:58:03 +0300 [thread overview]
Message-ID: <8da136c2-a4f8-bc3b-7c61-de29217153fa@gmail.com> (raw)
In-Reply-To: <4186d48a-ea7e-39c1-d1fa-1db3f6627a3a@datenfreihafen.org>
Hi Stefan,
On 1/5/22 23:27, Stefan Schmidt wrote:
>> + ret = usb_control_msg_recv(usb_dev, 0, ATUSB_REG_READ, ATUSB_REQ_FROM_DEV,
>> + 0, RG_PART_NUM, &atusb, 1, 1000, GFP_KERNEL);
>
> This needs to be written to &part_num and not &atusb.
>
Oh, stupid copy-paste error :( Thanks for catching this!
> Pretty nice for a first blind try without hardware. Thanks.
>
> Will let you know if I find anything else from testing.
Ok, will wait for test results. Thank you for your time ;)
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-01-05 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 14:49 [PATCH -next] ieee802154: atusb: move to new USB API Pavel Skripkin
2022-01-05 20:27 ` Stefan Schmidt
2022-01-05 20:58 ` Pavel Skripkin [this message]
2022-01-07 13:43 ` Stefan Schmidt
2022-01-07 13:46 ` Stefan Schmidt
2022-01-08 13:11 ` Pavel Skripkin
2022-01-08 13:18 ` [PATCH -next v2] " Pavel Skripkin
2022-01-10 8:57 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da136c2-a4f8-bc3b-7c61-de29217153fa@gmail.com \
--to=paskripkin@gmail.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).