Re: [PATCH net-next] netlink-specs: add rx-push to ethtool family

[Shannon Nelson <shannon.nelson@amd.com>]

On 2/13/23 8:32 PM, Jakub Kicinski wrote:
> Commit 5b4e9a7a71ab ("net: ethtool: extend ringparam set/get APIs for rx_push")
> added a new attr for configuring rx-push, right after tx-push.
> Add it to the spec, the ring param operation is covered by
> the otherwise sparse ethtool spec.

Thanks for catching that
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Cc: Shannon Nelson <shannon.nelson@amd.com>
> ---
>   Documentation/netlink/specs/ethtool.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 82f4e6f8ddd3..08b776908d15 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -171,6 +171,9 @@ doc: Partial family for Ethtool Netlink.
>         -
>           name: tx-push
>           type: u8
> +      -
> +        name: rx-push
> +        type: u8
> 
>     -
>       name: mm-stat
> @@ -320,6 +323,7 @@ doc: Partial family for Ethtool Netlink.
>               - tcp-data-split
>               - cqe-size
>               - tx-push
> +            - rx-push
>         dump: *ring-get-op
>       -
>         name: rings-set
> @@ -339,6 +343,7 @@ doc: Partial family for Ethtool Netlink.
>               - tcp-data-split
>               - cqe-size
>               - tx-push
> +            - rx-push
>       -
>         name: rings-ntf
>         doc: Notification for change in ring params.
> --
> 2.39.1
>