From: Dan Carpenter <dan.carpenter@linaro.org>
To: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
krzk@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: stmmac: remove the unnecessary argument of stmmac_remove_config_dt()
Date: Wed, 18 Dec 2024 11:47:05 +0300 [thread overview]
Message-ID: <8dcb6337-87d9-454d-8f71-295d69c5c785@stanley.mountain> (raw)
In-Reply-To: <20241218032230.117453-3-joe@pf.is.s.u-tokyo.ac.jp>
On Wed, Dec 18, 2024 at 12:22:30PM +0900, Joe Hattori wrote:
> static void devm_stmmac_remove_config_dt(void *data)
> {
> - struct plat_stmmacenet_data *plat = data;
> -
> - /* Platform data argument is unused */
> - stmmac_remove_config_dt(NULL, plat);
> + stmmac_remove_config_dt(data);
Instead of doing this, move the code from stmmac_remove_config_dt()
to here and delete the stmmac_remove_config_dt() function. Delete
the comments that mention stmmac_remove_config_dt().
- * Description: Devres variant of stmmac_probe_config_dt(). Does not require
- * the user to call stmmac_remove_config_dt() at driver detach.
This comment no longer makes sense.
regards,
dan carpenter
prev parent reply other threads:[~2024-12-18 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 3:22 [PATCH v2 0/2] net: stmmac: fix an OF node reference leak in error paths in stmmac_probe_config_dt() Joe Hattori
2024-12-18 3:22 ` [PATCH v2 1/2] net: stmmac: call of_node_put() and stmmac_remove_config_dt() " Joe Hattori
2024-12-18 8:43 ` Dan Carpenter
2024-12-19 2:45 ` Joe Hattori
2024-12-18 3:22 ` [PATCH v2 2/2] net: stmmac: remove the unnecessary argument of stmmac_remove_config_dt() Joe Hattori
2024-12-18 8:47 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dcb6337-87d9-454d-8f71-295d69c5c785@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox