From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD0F23CAE85; Wed, 1 Apr 2026 09:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775034085; cv=none; b=LUwgKC6fq0K++JNM8EOR9GLtC6V/khORdhTRHkDQWablMatjcbeyON9t3oXll05UA9B+YyUw69tQkRxOOIhf5T7WlEnLZjfKvDsWLi0HCWYkkCd6d8Zw3v9/RxOoi2jGn4QsrMWY+Fc2j7P1UAINNRW9HIOCLCyL896IF8MjpJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775034085; c=relaxed/simple; bh=pjlrfUH8eUQ+zCivUMUKUassfapoyoThebsNFDFzdp4=; h=Content-Type:MIME-Version:Message-Id:In-Reply-To:References: Subject:From:To:Cc:Date; b=YXSElQI/TCdojvbSK5Zl1QdMF4nr3QetyVaiIaSQByjPIQYQz9PYj1Q7Z7xvgpSYTA0UsR2NJ2pLMCdkuAJLWJ3lLcBavRLiW+hxNdbOW8TLj9UFo4Ow92voP02PbNkMFoyj8ZSOVxJk9xdqkWOUIB4NxrCffO6KhhuHk3CO5UU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pJ3SAr9E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pJ3SAr9E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB42C4CEF7; Wed, 1 Apr 2026 09:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775034085; bh=pjlrfUH8eUQ+zCivUMUKUassfapoyoThebsNFDFzdp4=; h=In-Reply-To:References:Subject:From:To:Cc:Date:From; b=pJ3SAr9Ex+S5hQMA/Ph7zhn38RBnzGKY6Ylul6pDXNW9SXNaowNqlsHSgRBVw+pTa P63PJOVxf0bcO+NkqlDNqUrxHTciHsLsg5H+UP2ivEgkoetFaorB+uNBKuSsybJVlC Ktybf8zDkelHT6s9jN4F+xz3ZjlZ3xWKf/ziMk/rH4Jlq43f2bIW8+wF+mfoAJYSfr oGJdR/JYFAYduL+eNbCDtW9bjbzOIDzrMTqRVssUniyyriI6aeoyfbmILuYivbpz8o nCwwnSDa+JbvwEH7gRcskKZM9Zc/xjLa134EPrD7HpiJikTIstysnOm/2U764xr6ws e6vLdrtlMXwwQ== Content-Type: multipart/mixed; boundary="===============8023301804951780972==" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <8dceda43e1d8fe0c9f3f34e035b5a4e66a40587db780e3722b88ad25e5797eec@mail.kernel.org> In-Reply-To: <20260401074509.1897527-6-dwmw2@infradead.org> References: <20260401074509.1897527-6-dwmw2@infradead.org> Subject: Re: [PATCH 5/6] net: Change CONFIG_INET to CONFIG_LEGACY_IP for IPv4-only code From: bot+bpf-ci@kernel.org To: dwmw2@infradead.org,saeedm@nvidia.com,leon@kernel.org,tariqt@nvidia.com,mbloch@nvidia.com,andrew+netdev@lunn.ch,davem@davemloft.net,edumazet@google.com,kuba@kernel.org,pabeni@redhat.com,horms@kernel.org,razor@blackwall.org,idosch@nvidia.com,martin.lau@linux.dev,daniel@iogearbox.net,john.fastabend@gmail.com,sdf@fomichev.me,ast@kernel.org,andrii@kernel.org,eddyz87@gmail.com,song@kernel.org,yonghong.song@linux.dev,kpsingh@kernel.org,haoluo@google.com,jolsa@kernel.org,kuniyu@google.com,willemb@google.com,dsahern@kernel.org,ncardwell@google.com,johannes@sipsolutions.net,pablo@netfilter.org,fw@strlen.de,phil@nwl.cc,gnault@redhat.com,dwmw@amazon.co.uk,kees@kernel.org,alazar@nvidia.com,gal@nvidia.com,paul@paul-moore.com,netdev@vger.kernel.org,linux-rdma@vger.kernel.org,linux-kernel@vger.kernel.org,oss-drivers@corigine.com,bridge@lists.linux.dev,bpf@vger.kernel.org,linux-wireless@vger.kernel.org,netfilter-devel@vger.kernel.org,coreteam@netfilter.org,torvalds@linux-foundation.org,jon.maddog.hall@gmail.com Cc: ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev Date: Wed, 1 Apr 2026 09:01:24 +0000 (UTC) --===============8023301804951780972== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > diff --git a/net/core/filter.c b/net/core/filter.c > index ad71ceefcb5e..ef99bd9fddd6 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c [ ... ] > @@ -6095,7 +6095,7 @@ static int bpf_fib_set_fwd_params(struct bpf_fib_lookup *params, u32 mtu) > } > #endif > > -#if IS_ENABLED(CONFIG_INET) > +#if IS_ENABLED(CONFIG_LEGACY_IP) > static int bpf_ipv4_fib_lookup(struct net *net, struct bpf_fib_lookup *params, > u32 flags, bool check_mtu) bpf_fib_set_fwd_params() above this hunk is still guarded by CONFIG_INET, and its only two callers are bpf_ipv4_fib_lookup() (now CONFIG_LEGACY_IP) and bpf_ipv6_fib_lookup() (CONFIG_IPV6). When CONFIG_INET=y with both CONFIG_LEGACY_IP=n and CONFIG_IPV6=n, bpf_fib_set_fwd_params() becomes an unused static function, which will produce a -Wunused-function warning and break CONFIG_WERROR builds. Should the guard on bpf_fib_set_fwd_params() be changed to something like: #if IS_ENABLED(CONFIG_LEGACY_IP) || IS_ENABLED(CONFIG_IPV6) to match its actual callers? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/23838411859 --===============8023301804951780972==--