netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, mkubecek@suse.cz,
	kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 3/3] net: treewide: Convert to netdev_ops_equal()
Date: Sun, 12 Jul 2020 15:19:22 -0700	[thread overview]
Message-ID: <8dfd5aa8-a765-defa-0c20-abdb2e78a3e0@gmail.com> (raw)
In-Reply-To: <20200712221625.287763-4-f.fainelli@gmail.com>



On 7/12/2020 3:16 PM, Florian Fainelli wrote:
> In order to support overloading of netdev_ops which can be done by
> specific subsystems such as DSA, utilize netdev_ops_equal() which allows
> a network driver implementing a ndo_equal operation to still qualify
> whether a net_device::netdev_ops is equal or not to its own.
> 
> Mechanical conversion done by spatch with the following SmPL patch:
> 
>     @@
>     struct net_device *n;
>     const struct net_device_ops o;
>     identifier netdev_ops;
>     @@
> 
>     - n->netdev_ops != &o
>     + !netdev_ops_equal(n, &o)
> 
>     @@
>     struct net_device *n;
>     const struct net_device_ops o;
>     identifier netdev_ops;
>     @@
> 
>     - n->netdev_ops == &o
>     + netdev_ops_equal(n, &o)
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---

I will be waiting for feedback before spinning a v2, but the changes to
net/openvswitch are no longer necessary and should instead using
__netdev_ops_equal(), sorry for missing that before sending.
-- 
Florian

  reply	other threads:[~2020-07-12 22:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12 22:16 [PATCH net-next 0/3] net: Preserve netdev_ops equality tests Florian Fainelli
2020-07-12 22:16 ` [PATCH net-next 1/3] net: Introduce netdev_ops_equal Florian Fainelli
2020-07-12 22:16 ` [PATCH net-next 2/3] net: dsa: Implement ndo_equal for CPU port net_device Florian Fainelli
2020-07-12 22:16 ` [PATCH net-next 3/3] net: treewide: Convert to netdev_ops_equal() Florian Fainelli
2020-07-12 22:19   ` Florian Fainelli [this message]
2020-07-13 20:34   ` Jakub Kicinski
2020-07-13 20:09 ` [PATCH net-next 0/3] net: Preserve netdev_ops equality tests Jakub Kicinski
2020-07-13 21:20   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dfd5aa8-a765-defa-0c20-abdb2e78a3e0@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).