From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Taku Izumi <izumi.taku@jp.fujitsu.com>,
netdev@vger.kernel.org, davem@davemloft.net
Cc: isimatu.yasuaki@jp.fujitsu.com
Subject: Re: [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave
Date: Tue, 10 May 2016 16:13:41 +0300 [thread overview]
Message-ID: <8e0d4e29-30b4-af2d-733f-4cf9d229237c@cogentembedded.com> (raw)
In-Reply-To: <1462843729-32414-1-git-send-email-izumi.taku@jp.fujitsu.com>
Hello.
On 5/10/2016 4:28 AM, Taku Izumi wrote:
> commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().
scripts/checkpatch.pl now enforces a certain commit citing style, yours
doesn't match it.
> This spin_lock_irqsave() is obviously unnecessary.
>
> This patch eliminates unnecessary spin_lock_irqsave() in
> fjes_change_mtu()
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
[...]
The "Fixes:" tag would also be in order...
MBR, Sergei
prev parent reply other threads:[~2016-05-10 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 1:28 [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave Taku Izumi
2016-05-10 2:06 ` David Miller
2016-05-10 13:13 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0d4e29-30b4-af2d-733f-4cf9d229237c@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox