From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
fengguang.wu@intel.com, dcbw@redhat.com, jiri@resnulli.us,
stephen@networkplumber.org, David.Laight@aculab.com,
marcel@holtmann.org, netdev-owner@vger.kernel.org
Subject: Re: [PATCH net-next 1/3 v7] net: ether: Add support for multiplexing and aggregation type
Date: Mon, 21 Aug 2017 23:27:13 -0600 [thread overview]
Message-ID: <8e0f6382e5770bb32efa342b1fe5cc81@codeaurora.org> (raw)
In-Reply-To: <20170822010208.GA24555@lunn.ch>
>> +#define ETH_P_MAP 0xDA1A /* Multiplexing and
>> Aggregation Protocol
>> + * NOT AN OFFICIALLY REGISTERED ID ]
>> + */
>
> Hi Subash
>
> This list is sorted. So this entry should go earlier.
>
>> + netdev_info(real_dev, "Removed from rmnet\n");
>
> I would probably turn all your netdev_info()s into netdev_dbg()s. You
> seem to be spamming the kernel log quite a bit.
>
Hi Andrew
I'll make these changes and post v8.
next prev parent reply other threads:[~2017-08-22 5:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 22:36 [PATCH net-next 0/3 v7] Add support for rmnet driver Subash Abhinov Kasiviswanathan
2017-08-21 22:36 ` [PATCH net-next 1/3 v7] net: ether: Add support for multiplexing and aggregation type Subash Abhinov Kasiviswanathan
2017-08-22 1:02 ` Andrew Lunn
2017-08-22 5:27 ` Subash Abhinov Kasiviswanathan [this message]
2017-08-21 22:36 ` [PATCH net-next 2/3 v7] net: arp: Add support for raw IP device Subash Abhinov Kasiviswanathan
2017-08-21 22:36 ` [PATCH net-next 3/3 v7] drivers: net: ethernet: qualcomm: rmnet: Initial implementation Subash Abhinov Kasiviswanathan
2017-08-22 1:17 ` Andrew Lunn
2017-08-24 19:15 ` David Miller
2017-08-24 22:45 ` Subash Abhinov Kasiviswanathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0f6382e5770bb32efa342b1fe5cc81@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=David.Laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=jiri@resnulli.us \
--cc=marcel@holtmann.org \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).