From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH net-next v1 04/11] net: usb: lan78xx: Add error handling to lan78xx_get_regs
Date: Tue, 10 Dec 2024 03:03:54 +0100 [thread overview]
Message-ID: <8e251cd2-00a2-484f-a628-8abe32fb772a@lunn.ch> (raw)
In-Reply-To: <20241209130751.703182-5-o.rempel@pengutronix.de>
On Mon, Dec 09, 2024 at 02:07:44PM +0100, Oleksij Rempel wrote:
> Update `lan78xx_get_regs` to handle errors during register and PHY
> reads. Log warnings for failed reads and exit the function early if an
> error occurs. This ensures that invalid data is not returned to users.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-12-10 2:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 13:07 [PATCH net-next v1 00/11] lan78xx: Preparations for PHYlink Oleksij Rempel
2024-12-09 13:07 ` [PATCH net-next v1 01/11] net: usb: lan78xx: Add error handling to lan78xx_setup_irq_domain Oleksij Rempel
2024-12-10 2:00 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 02/11] net: usb: lan78xx: Add error handling to lan78xx_init_mac_address Oleksij Rempel
2024-12-10 2:01 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 03/11] net: usb: lan78xx: Add error handling to lan78xx_set_mac_addr Oleksij Rempel
2024-12-10 2:02 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 04/11] net: usb: lan78xx: Add error handling to lan78xx_get_regs Oleksij Rempel
2024-12-10 2:03 ` Andrew Lunn [this message]
2024-12-11 2:53 ` Jakub Kicinski
2024-12-09 13:07 ` [PATCH net-next v1 05/11] net: usb: lan78xx: Simplify lan78xx_update_reg Oleksij Rempel
2024-12-10 2:04 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 06/11] net: usb: lan78xx: Fix return value handling in lan78xx_set_features Oleksij Rempel
2024-12-10 2:04 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 07/11] net: usb: lan78xx: Use ETIMEDOUT instead of ETIME in lan78xx_stop_hw Oleksij Rempel
2024-12-10 2:08 ` Andrew Lunn
2024-12-13 14:37 ` Oleksij Rempel
2024-12-09 13:07 ` [PATCH net-next v1 08/11] net: usb: lan78xx: Use function-specific label in lan78xx_mac_reset Oleksij Rempel
2024-12-10 2:08 ` Andrew Lunn
2024-12-11 2:55 ` Jakub Kicinski
2024-12-09 13:07 ` [PATCH net-next v1 09/11] net: usb: lan78xx: Improve error handling in lan78xx_phy_wait_not_busy Oleksij Rempel
2024-12-10 2:11 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 10/11] net: usb: lan78xx: Rename lan78xx_phy_wait_not_busy to lan78xx_mdiobus_wait_not_busy Oleksij Rempel
2024-12-10 2:12 ` Andrew Lunn
2024-12-09 13:07 ` [PATCH net-next v1 11/11] net: usb: lan78xx: Improve error handling in WoL operations Oleksij Rempel
2024-12-10 2:13 ` Andrew Lunn
2024-12-11 2:56 ` Jakub Kicinski
2024-12-11 2:52 ` [PATCH net-next v1 00/11] lan78xx: Preparations for PHYlink Jakub Kicinski
2024-12-11 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e251cd2-00a2-484f-a628-8abe32fb772a@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).