From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support
Date: Thu, 23 May 2019 06:08:42 +0200 [thread overview]
Message-ID: <8e34e321-fe1d-0dea-0d85-246876c43e14@gmail.com> (raw)
In-Reply-To: <20190522205851.GA15257@lunn.ch>
On 22.05.2019 22:58, Andrew Lunn wrote:
> On Wed, May 22, 2019 at 09:58:32PM +0200, Heiner Kallweit wrote:
>> So far we didn't support mode USXGMII, and in order to not break the
>> two Freescale boards mode XGMII was accepted for the AQR107 family
>> even though it doesn't support XGMII. Add USXGMII support to the
>> Aquantia PHY driver and change the phy connection type for the two
>> boards.
>>
>> As an additional note: Even though the handle is named aqr106
>> there seem to be LS1046A boards with an AQR107.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 +-
>> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 2 +-
>> drivers/net/phy/aquantia_main.c | 6 +++++-
>> 3 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
>> index 4223a2352..c2ce1a611 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
>> @@ -139,7 +139,7 @@
>>
>> ethernet@f0000 { /* 10GEC1 */
>> phy-handle = <&aqr105_phy>;
>> - phy-connection-type = "xgmii";
>> + phy-connection-type = "usxgmii";
>> };
>>
>> mdio@fc000 {
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
>> index 6a6514d0e..f927a8a25 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
>> @@ -147,7 +147,7 @@
>>
>> ethernet@f0000 { /* 10GEC1 */
>> phy-handle = <&aqr106_phy>;
>> - phy-connection-type = "xgmii";
>> + phy-connection-type = "usxgmii";
>> };
>>
>> ethernet@f2000 { /* 10GEC2 */
>> diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c
>> index 0fedd28fd..3f24c42a8 100644
>> @@ -487,7 +491,7 @@ static int aqr107_config_init(struct phy_device *phydev)
>> /* Check that the PHY interface type is compatible */
>> if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
>> phydev->interface != PHY_INTERFACE_MODE_2500BASEX &&
>> - phydev->interface != PHY_INTERFACE_MODE_XGMII &&
>> + phydev->interface != PHY_INTERFACE_MODE_USXGMII &&
>> phydev->interface != PHY_INTERFACE_MODE_10GKR)
>> return -ENODEV;
>
> Hi Heiner
>
> Just to reiterate Florian's point. We need to be careful with device
> tree blobs. We should try not to break them, at least not for a few
> cycles.
>
> I would much prefer to see a
>
> WARN_ON(phydev->interface == PHY_INTERFACE_MODE_XGMII,
> "Your devicetree is out of date, please update it");
>
> and accept XGMII for this cycle. These are development boards, so in
> theory users are developers, so should know how to update the DT.
>
I see your point. Then I'll just change phylib and will let the NXP
guys change the board DTS.
> Andrew
>
Heiner
prev parent reply other threads:[~2019-05-23 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 19:56 [PATCH net-next 0/2] net: phy: add interface mode PHY_INTERFACE_MODE_USXGMII Heiner Kallweit
2019-05-22 19:57 ` [PATCH net-next 1/2] " Heiner Kallweit
2019-05-22 20:06 ` Florian Fainelli
2019-05-22 20:20 ` Heiner Kallweit
2019-05-22 19:58 ` [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support Heiner Kallweit
2019-05-22 20:07 ` Florian Fainelli
2019-05-22 20:18 ` Heiner Kallweit
2019-05-22 20:29 ` Florian Fainelli
2019-05-22 20:58 ` Andrew Lunn
2019-05-23 4:08 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e34e321-fe1d-0dea-0d85-246876c43e14@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=madalin.bucur@nxp.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).