From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: Re: [PATCH net-next v4 12/13] netlink: specs: Add ethernet port listing with ethtool
Date: Wed, 4 Feb 2026 17:53:01 +0100 [thread overview]
Message-ID: <8e355184-1593-4bac-bc57-40258cd56c78@bootlin.com> (raw)
In-Reply-To: <20260204081413.7bab62ab@kernel.org>
Hi Jakub
On 04/02/2026 17:14, Jakub Kicinski wrote:
> On Tue, 3 Feb 2026 18:28:36 +0100 Maxime Chevallier wrote:
>> +Request contents:
>> +
>> +==================================== ====== =================================
>> + ``ETHTOOL_A_PORT_HEADER`` nested request header
>> + ``ETHTOOL_A_PORT_ID`` u32 port id
>> + ==================================== ====== ===============================
>
> No idea what happened but suddenly last doc build run started noticing
> that this table is malformed. Even tho the patches have been present in
> previous builds already and there was no error. Very odd. But the table
> does look wonky..
>
> Documentation/networking/ethtool-netlink.rst:2538: ERROR: Malformed table.
> Bottom/header table border does not match top border.
>
> ==================================== ====== =================================
> ``ETHTOOL_A_PORT_HEADER`` nested request header
> ``ETHTOOL_A_PORT_ID`` u32 port id
> ==================================== ====== ===============================
Yeah I noticed too late... Simon made the same comment on V3, but his
review and my V4 crossed and the issue is still there, as are a few
other ones like the smatch problem :(
I'll slow down my horses a bit :)
Thanks,
Maxime
next prev parent reply other threads:[~2026-02-04 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 17:28 [PATCH net-next v4 00/13] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 01/13] net: phy: initialize the port support based on the PHY's for OF ports Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 02/13] net: phy: phy_port: Cleanup the of-parsing logic for phy_port Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 03/13] net: phy: phy_port: Correctly recompute the port's linkmodes Maxime Chevallier
2026-02-04 7:39 ` Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 04/13] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 05/13] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 06/13] net: phylink: Register a phy_port for MAC-driven SFP busses Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 07/13] net: phy: Create SFP phy_port before registering upstream Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 08/13] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 09/13] net: phylink: " Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 10/13] net: phy: phy_port: Store information about a MII port's vacant state Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 11/13] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-02-03 17:28 ` [PATCH net-next v4 12/13] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-02-04 16:14 ` Jakub Kicinski
2026-02-04 16:53 ` Maxime Chevallier [this message]
2026-02-03 17:28 ` [PATCH net-next v4 13/13] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e355184-1593-4bac-bc57-40258cd56c78@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox