From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA3B33DECB; Wed, 4 Feb 2026 16:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223995; cv=none; b=hxNOyQuL1TOABbUqaoHxpVMsWk0kCL39BYyD/pSHkbQZCTLCXnJaTkPWKK7pTZ59I4FRUk2Cb8jcUhZBakS3MjCPYsOrNpsW3jvllogz8kDNT6urCG78s8thPEo8nSFVQLj74smYSxhzK/S6KSLHdki+g6KtGWod9aH5IeR86IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223995; c=relaxed/simple; bh=CWsZlV5vgEUXwSlVyA8def71CkN4oknRgrw0BEcdEYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ryXLxFXLpCSyYvY0Cbdgo5pcFsZEIHDhIA1x2l/524F8VKPfdE5exARhwbKc7uUKBoAlmpZBZgFMH3VzGlxlaatyipTSTgGn4wJC7mNsvJxFZRMPU0aS2jFgvZK5EXqKbHHk0e/TGd8pxe3Y8CH1Tdhp1HFILWr1QcHsYiTVLVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=khDme/4m; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="khDme/4m" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C86B61A0D18; Wed, 4 Feb 2026 16:53:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 931A160705; Wed, 4 Feb 2026 16:53:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9F1D9119A865B; Wed, 4 Feb 2026 17:53:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770223991; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=QDPf8MZb/op4nLM/mCR37g1vR6uE9/uLKPsuBNKnDP0=; b=khDme/4mJgdYnAX+ZFKEMCwtaKPWZZ9s21E3VWwQbOu1UDr4f2ZMmvyXp/fT8XxUG7mE+u 6jN9IKDiItQQufm1RHQ/VkUdKONZf2xBBgPelqLp9gF13tJNDDTwJuB+l8meXlM7ooYonk 70CzJV2K+j0hxNnRaHPqexak7XcWylXWJHx2AidRmK+QFTWJ0GpsGgeqOgj9Ie5Ek1hqQI 9kBE4hrdGbUtC8Gon0Otj141zEsN46arTwY4NQVeBBfWEiMDxL6WF/8aEMVkQ8aQFPiiaH 4fyBVhQrxHkrtmRDroaLQSx1WreB3teuxWHKB7aawXdqIlAEiA2VBw5e1tpsPw== Message-ID: <8e355184-1593-4bac-bc57-40258cd56c78@bootlin.com> Date: Wed, 4 Feb 2026 17:53:01 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 12/13] netlink: specs: Add ethernet port listing with ethtool To: Jakub Kicinski Cc: davem@davemloft.net, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20260203172839.548524-1-maxime.chevallier@bootlin.com> <20260203172839.548524-13-maxime.chevallier@bootlin.com> <20260204081413.7bab62ab@kernel.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20260204081413.7bab62ab@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub On 04/02/2026 17:14, Jakub Kicinski wrote: > On Tue, 3 Feb 2026 18:28:36 +0100 Maxime Chevallier wrote: >> +Request contents: >> + >> +==================================== ====== ================================= >> + ``ETHTOOL_A_PORT_HEADER`` nested request header >> + ``ETHTOOL_A_PORT_ID`` u32 port id >> + ==================================== ====== =============================== > > No idea what happened but suddenly last doc build run started noticing > that this table is malformed. Even tho the patches have been present in > previous builds already and there was no error. Very odd. But the table > does look wonky.. > > Documentation/networking/ethtool-netlink.rst:2538: ERROR: Malformed table. > Bottom/header table border does not match top border. > > ==================================== ====== ================================= > ``ETHTOOL_A_PORT_HEADER`` nested request header > ``ETHTOOL_A_PORT_ID`` u32 port id > ==================================== ====== =============================== Yeah I noticed too late... Simon made the same comment on V3, but his review and my V4 crossed and the issue is still there, as are a few other ones like the smatch problem :( I'll slow down my horses a bit :) Thanks, Maxime