From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [patch net-next v7 03/13] net: sched: avoid usage of tp->q in tcf_classify Date: Wed, 10 Jan 2018 09:17:28 -0700 Message-ID: <8e52b826-c5b6-e144-b292-f7184d45f577@gmail.com> References: <20180109140731.1022-1-jiri@resnulli.us> <20180109140731.1022-4-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:42090 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965891AbeAJQRb (ORCPT ); Wed, 10 Jan 2018 11:17:31 -0500 Received: by mail-pg0-f67.google.com with SMTP id q67so11170938pga.9 for ; Wed, 10 Jan 2018 08:17:31 -0800 (PST) In-Reply-To: <20180109140731.1022-4-jiri@resnulli.us> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/9/18 7:07 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Use block index in the messages instead. > > Signed-off-by: Jiri Pirko > --- > net/sched/cls_api.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 9b45950..31e91dc 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -672,8 +672,9 @@ int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp, > #ifdef CONFIG_NET_CLS_ACT > reset: > if (unlikely(limit++ >= max_reclassify_loop)) { > - net_notice_ratelimited("%s: reclassify loop, rule prio %u, protocol %02x\n", > - tp->q->ops->id, tp->prio & 0xffff, > + net_notice_ratelimited("%u: reclassify loop, rule prio %u, protocol %02x\n", if you are dumping index instead of prio shouldn't the 'rule prio' above be adjusted? > + tp->chain->block->index, > + tp->prio & 0xffff, > ntohs(tp->protocol)); > return TC_ACT_SHOT; > } >