From: "Paul Marks" <paul@pmarks.net>
To: "David Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: When should kfree_skb be used?
Date: Thu, 8 May 2008 23:55:41 -0700 [thread overview]
Message-ID: <8e5b27790805082355x968c4e3p1d40f3acfec3f123@mail.gmail.com> (raw)
In-Reply-To: <20080508.234122.20422788.davem@davemloft.net>
On Thu, May 8, 2008 at 11:41 PM, David Miller <davem@davemloft.net> wrote:
> From: "Paul Marks" <paul@pmarks.net>
> Date: Thu, 8 May 2008 23:34:59 -0700
>
>> I've been looking at more uses of pskb_may_pull(), and almost all of
>> them seem to kfree_skb() after a failure. Could this occurence in
>> sit.c be a bug? It looks like this line was added by davem for linux
>> 2.4.4 in 2001, and hasn't changed since.
>
> Yep, looks like a leak. The following should fix it, thanks
> for the report:
>
Ok, cool, that makes more sense now.
prev parent reply other threads:[~2008-05-09 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 4:49 When should kfree_skb be used? Paul Marks
2008-05-09 6:34 ` Paul Marks
2008-05-09 6:41 ` David Miller
2008-05-09 6:55 ` Paul Marks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e5b27790805082355x968c4e3p1d40f3acfec3f123@mail.gmail.com \
--to=paul@pmarks.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).