netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom
Date: Wed, 21 Apr 2021 11:26:17 +0800	[thread overview]
Message-ID: <8e8e8f5c-16aa-668c-9567-b5c1f91e19dc@redhat.com> (raw)
In-Reply-To: <1618922142.0493622-1-xuanzhuo@linux.alibaba.com>


在 2021/4/20 下午8:35, Xuan Zhuo 写道:
>> I realize this has been merged to net-next already, but I'm getting a
>> use-after-free with KASAN in page_to_skb() with this patch. Reverting this
>> change fixes the UAF. I've included the KASAN dump below, and a couple of
>> comments inline.
> I think something went wrong, this was merged before it was acked. Based on the
> Jason Wang's comments, there are still some tests that have not been done?
>
> If it has been merged, what should I do now, can I make up the test?


I think so, please test net-next which should contains the fixes from Eric.

Thanks


>
>
> Thanks.
>


       reply	other threads:[~2021-04-21  3:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1618922142.0493622-1-xuanzhuo@linux.alibaba.com>
2021-04-21  3:26 ` Jason Wang [this message]
     [not found] <1619491565.7682261-1-xuanzhuo@linux.alibaba.com>
2021-04-28  1:21 ` [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom Jason Wang
2021-04-16  9:16 Xuan Zhuo
2021-04-19  3:10 ` Jason Wang
2021-04-19 16:48 ` David Ahern
2021-04-20  2:49   ` Jason Wang
2021-04-19 23:29 ` Mat Martineau
2021-04-20  2:38   ` Jason Wang
2021-04-20  2:41     ` Jason Wang
2021-04-20  9:28 ` Eric Dumazet
2021-04-22 11:13 ` Ido Schimmel
     [not found]   ` <1619093551.9680612-1-xuanzhuo@linux.alibaba.com>
2021-04-22 12:55     ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e8e8f5c-16aa-668c-9567-b5c1f91e19dc@redhat.com \
    --to=jasowang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).