Re: [PATCH net-next] lwtunnel: fix error path in lwtunnel_fill_encap()

David Ahern
2017-04-29T13:03:12Z

On 4/28/17 7:03 AM, Dan Carpenter wrote:
> We recently added a check to see if nla_nest_start() fails. There are
> two issues with that. First, if it fails then I don't think we should
> call nla_nest_cancel(). Second, it's slightly convoluted but the
> current code returns success but we should return -EMSGSIZE instead.
>
> Fixes: a50fe0ffd76f ("lwtunnel: check return value of nla_nest_start")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>

Acked-by: David Ahern <dsa@cumulusnetworks.com>