From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] arp: fix arp_filter on l3slave devices Date: Thu, 5 Apr 2018 08:40:48 -0600 Message-ID: <8ea161a0-b164-8f05-5026-d416f17fbdfb@gmail.com> References: <1522916738-192046-1-git-send-email-mfadon@teldat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Miguel Fadon Perlines , netdev@vger.kernel.org, David Miller Return-path: Received: from mail-pl0-f46.google.com ([209.85.160.46]:41742 "EHLO mail-pl0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbeDEOkc (ORCPT ); Thu, 5 Apr 2018 10:40:32 -0400 Received: by mail-pl0-f46.google.com with SMTP id bj1-v6so16964838plb.8 for ; Thu, 05 Apr 2018 07:40:32 -0700 (PDT) In-Reply-To: <1522916738-192046-1-git-send-email-mfadon@teldat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/5/18 2:25 AM, Miguel Fadon Perlines wrote: > arp_filter performs an ip_route_output search for arp source address and > checks if output device is the same where the arp request was received, > if it is not, the arp request is not answered. > > This route lookup is always done on main route table so l3slave devices > never find the proper route and arp is not answered. > > Passing l3mdev_master_ifindex_rcu(dev) return value as oif fixes the > lookup for l3slave devices while maintaining same behavior for non > l3slave devices as this function returns 0 in that case. > > Signed-off-by: Miguel Fadon Perlines > --- > net/ipv4/arp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: David Ahern DaveM: this is a day 1 bug for VRF. Best guess at a Fixes tag would be: Fixes: 613d09b30f8b ("net: Use VRF device index for lookups on TX") It would be good to get this into stable releases 4.9 and up. Thanks,