From: Jacob Keller <jacob.e.keller@intel.com>
To: Richard Cochran <richardcochran@gmail.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Aya Levin <ayal@nvidia.com>, Gal Pressman <gal@nvidia.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info
Date: Fri, 2 Dec 2022 14:11:38 -0800 [thread overview]
Message-ID: <8ea1fe78-c957-1ffd-f4e9-8740c451a40f@intel.com> (raw)
In-Reply-To: <Y4pj1Xb6mrIWxLEm@hoboy.vegasvil.org>
On 12/2/2022 12:45 PM, Richard Cochran wrote:
> On Fri, Dec 02, 2022 at 12:15:27PM -0800, Rahul Rameshbabu wrote:
>> The current state of the ptp driver provides the ability to query the frequency
>> of the ptp clock device by caching the frequency values used in previous
>> adjustments done through the ptp driver. This works great when the ptp driver is
>> the only means for changing the clock frequency. However, some devices support
>> ways to adjust the frequency outside the ptp driver stack.
>
> The kernel provides no other way to adjust the frequency.
>
> So NAK on this series.
>
> Thanks,
> Richard
>
Agreed. Just because your driver does something silly such as modifying
the frequency out of band of PTP stack doesn't mean we need to support it.
As for running multiple ptp4l instances on the same PTP clock, we
already have the ability to report the frequency out to user space. The
ptp4l application checks this at init but then begins assuming that it
is the only software controlling the clock. That seems like a reasonable
assumption to me. If you want to write your own user space software
which handles this, you already have the mechanism to do so.
Thanks,
Jake
prev parent reply other threads:[~2022-12-02 22:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 20:15 [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info Rahul Rameshbabu
2022-12-02 20:15 ` [PATCH net-next 1/2] ptp: Add .getfine function to support reporting frequency offset from hardware Rahul Rameshbabu
2022-12-02 20:15 ` [PATCH net-next 2/2] net/mlx5: Implement ptp_clock_info .getfine function Rahul Rameshbabu
2022-12-03 10:06 ` kernel test robot
2022-12-03 11:06 ` kernel test robot
2022-12-02 20:45 ` [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info Richard Cochran
2022-12-02 22:11 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea1fe78-c957-1ffd-f4e9-8740c451a40f@intel.com \
--to=jacob.e.keller@intel.com \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).