Re: [PATCH net-next v2 1/3] net/sched: Introduce action hash

kernel test robot
2020-07-01T22:24:42Z

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

Hi Ariel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url: https://github.com/0day-ci/linux/commits/Ariel-Levkovich/TC-datapath-hash-api/20200702-025138
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2b04a66156159592156a97553057e8c36de2ee70
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> net/sched/act_hash.c:351:24: error: initialization of 'void (*)(struct tc_action *, u64, u64, u64, u64, bool)' {aka 'void (*)(struct tc_action *, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, _Bool)'} from incompatible pointer type 'void (*)(struct tc_action *, u64, u32, u64, bool)' {aka 'void (*)(struct tc_action *, long long unsigned int, unsigned int, long long unsigned int, _Bool)'} [-Werror=incompatible-pointer-types]
351 | .stats_update = tcf_hash_stats_update,
| ^~~~~~~~~~~~~~~~~~~~~
net/sched/act_hash.c:351:24: note: (near initialization for 'act_hash_ops.stats_update')
cc1: some warnings being treated as errors

vim +351 net/sched/act_hash.c

340
341 static struct tc_action_ops act_hash_ops = {
342 .kind = "hash",
343 .id = TCA_ID_HASH,
344 .owner = THIS_MODULE,
345 .act = tcf_hash_act,
346 .dump = tcf_hash_dump,
347 .init = tcf_hash_init,
348 .cleanup = tcf_hash_cleanup,
349 .walk = tcf_hash_walker,
350 .lookup = tcf_hash_search,
> 351 .stats_update = tcf_hash_stats_update,
352 .size = sizeof(struct tcf_hash),
353 };
354

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65092 bytes --]